Current location deleted when editing asset

[docmedicus]

Debug mode

• I have enabled debug mode
• I have read checked the Common Issues page

Describe the bug

As described in #13682 we almost always loose the current location when editing assets. We set the current location using asset audits to track the assets actual location. When making changes to the asset, the current location seems to get lost and the asset reverts to the default location (if set) or no location.

Is this intended behaviour? We currently have to audit all assets again after editing them just to update the current location.

It would also be great if there was another way to set the current location.

Reproduction steps

1. Audit asset and set location
2. Edit asset and Save

Expected behavior

The current location is kept through asset edits.

Screenshots

No response

Snipe-IT Version

6.1.2

Operating System

Ubuntu

Web Server

Apache

PHP Version

8.1.2

Operating System

No response

Browser

No response

Version

No response

Device

No response

Operating System

No response

Browser

No response

Version

No response

Error messages

No response

Additional context

No response

[welcome]

👋 Thanks for opening your first issue here! If you're reporting a 🐞 bug, please make sure you include steps to reproduce it. We get a lot of issues on this repo, so please be patient and we will get back to you as soon as we can.

[Godmartinz]

Hi @docmedicus,

Are you on the latest version?

You will want to make sure that the checkbox below is checked if you want the asset's current location to change permanently. If you don't mark this it will just make a note of the location in the audit log.

Let me know if you have any more questions or concerns.

[docmedicus]

Hi @Godmartinz ,

yes, I have now recreated the problem on the latest version. We do set the location via auditing and checking "Update Asset Location", since this seems to be the only way to set the current location. (why is that?)

If I then edit the asset (e.g. adding supplier informaton and purchase date), the current location is removed from the asset (I can also see this in the assets history).

I assume that either the current location is removed, or reset to the default location (which we do not set any more, because we see no practical use for it). Either way I do not understand the behaviour. Is this intended? We are currently silently loosing asset locations when not manually checking them after each asset edit.

[docmedicus]

After having a quick look at the code I suspect the following line(s) to be the cause of my confusion:

snipe-it/app/Http/Controllers/Assets/AssetsController.php

Line 152 in 776b16d

if ($asset->assigned_to == '') {

If the asset is update and not currently checked out, the current location is reset to the default location. What is the reasoning behind this? Can an asset not be at a certain location (as determined by an audit) and then be edited (e.g. to add an invoice). Why does the current location have to be changed in this case?

Also, why is it not possible to set the current location apart from forcing it through an audit?

[NMX-Drew]

I'd like to +1 this issue too. having to re-set the location after every edit or sign in/out is not ideal.

[DrekiDegga]

I think the idea is that if an item is not checked out to a user, it would be "on the shelf" at it's default location, no?

If you store the item somewhere when it isn't in use, shouldn't that be it's default location?