Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrating from libnetcdf to ncdf4 #178

Closed
sneumann opened this issue Sep 7, 2018 · 2 comments
Closed

Migrating from libnetcdf to ncdf4 #178

sneumann opened this issue Sep 7, 2018 · 2 comments
Assignees

Comments

@sneumann
Copy link
Owner

sneumann commented Sep 7, 2018

Hi, to avoid the recurring Linking Hell with HDF5 and netCDF,
we could drop https://github.com/sneumann/mzR/blob/master/src/rnetCDF.c
and rewrite https://github.com/sneumann/mzR/blob/master/R/methods-mzRnetCDF.R
to use https://cran.r-project.org/package=ncdf4 instead.
Yours, Steffen

@lgatto
Copy link
Collaborator

lgatto commented Sep 7, 2018

I would definitely be in favour of re-using the ncdf4 package to limit external dependencies on our direct end, but won't be able to commit time to rewrite the mzRnetCDF methods.

@sneumann
Copy link
Owner Author

sneumann commented Sep 10, 2018

I have a first go at dfbd825
please beat it and report shortcomings before we can cleanup and merge

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants