Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support custom pool keys #296

Open
maxsalven opened this issue Jan 13, 2025 · 1 comment
Open

Support custom pool keys #296

maxsalven opened this issue Jan 13, 2025 · 1 comment

Comments

@maxsalven
Copy link

maxsalven commented Jan 13, 2025

I have an app that sends Apple Push Notifications on behalf of multiple different developer accounts.

Apple's APNs server requires any given connection to be used exclusively by a single developer's authentication tokens.

https://developer.apple.com/documentation/usernotifications/establishing-a-token-based-connection-to-apns

APNs doesn’t support authentication tokens from multiple developer accounts over a single connection.

You can’t map a connection to APNs to multiple teams. If you manage APNs for multiple developer accounts, open separate connection pools for each of them.

As part of the authentication process, APNs relates a team ID and associated bundle IDs to a connection on the first push. After the authentication process, attempting to associate a different team or sending a push to a newly added bundle ID causes an error. To send remote notifications to a new topic, add the topic to your team in App Store Connect and create new connections to APNs.

Hence I can't use the URL schema as the pool identifier with Finch, I need a way to manually associate a connection pool with a team (developer account) ID. Essentially I need multiple separate pools which happen to connect to the same URL.

Note that this is exclusively for HTTP2.

Is this something that could conceivably be supported in Finch?

@sneako
Copy link
Owner

sneako commented Jan 16, 2025

Good point, I'm surprised this issue hadn't been raised earlier.

It should be quite trivial to add an optional pool alias option.

As a temporary workaround, you could consider starting separate Finch instances for each separate account, but this new alias option sounds like a reasonable feature.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants