Debugging GS instruments with ADLMidiPlay

[sneakernets]

A little trick I found with GS instruments (to knock it out of XG mode)

Line 989 of adlmidi_midiplay.cpp:

        bank = (uint16_t(Ch[channel].bank_msb) * 256) + uint16_t(Ch[channel].bank_lsb);

Should be

        bank = (uint16_t(Ch[channel].bank_msb)) + uint16_t(Ch[channel].bank_lsb);

This allows GS to work for now.

[sneakernets]

This totally breaks XG, notes will not play

[Wohlstand]

Numeric of GS banks is going as:

Wher real combined MSB and LSB by my formula when thinking as Bank Number is unsigned 16-bit integer. Same you will catch inside of MIDI file (MSB event is GS-specific event. LSB bank event is XG event. Possible to use both of them).

Real	MSB
0	0
256	1
512	2
768	3
1024	4
1280	5
1536	6
1792	7
2048	8
2304	9
4096	16
6144	24
8192	32

So, when I have set MSB as 8:

and when I have made a dummy MIDI file that uses this bank:

Then, it working fine!

gs-ukulele-test.mid.gz

Just for a comparison, same test which uses zero bank:

gs-jazz-test.mid.gz

[Wohlstand]

One note came from this issue: Wohlstand/libADLMIDI#136
Extra LSB bank numbers are giving next additions:

1 being SC55, 2 being SC88, 3 SC88 Pro, 4 SC8820

The 0'th LSB is the default fallback, and 1,2,3,4 are meaning different version of same instrument per each synthesizer.

libADLMIDI now supports correct MSB and LSB logic for GS on it's backend, the one thing is left - to polish the bank itself to equip it with necessary instruments.

[freq-mod]

...wait.
Let's say we have a GS Bank no. 8 (MSB=8). It's needed to create a separate bank for SC-55 only instruments (LSB=1), another separate bank for SC-88 instruments (LSB=2) and so on?

[Wohlstand]

If there are different - yes, but keep the LSB=0 to be a default fallback. When given LSB is missing, it falls into 0 on the same MSB.