fix: Cannot read property watch of undefined in jest v22 version #197
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks! |
|
should we also publish a 3.9.1 version to resolve this bug? because 4.0.0 version only support jest v24+ |
|
I don't think so, it doesn't worth it. Migrating to Jest 24 is not a big deal. |
|
yeah, upgrade Jest is not a big deal, but if we dont plan to support Jest v22, should we update the README to explain this? |
|
@xiaoyuhen I think the readme is enough clear about that. We will just drop the line about Jest v22 in one or two months and it will be enough. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
close #195
Test plan