-
Notifications
You must be signed in to change notification settings - Fork 289
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
suport jest v24 #196
suport jest v24 #196
Conversation
Because Jest@24 has some bug, we are unable to support it for the time being. We will merge this PR as soon as possible after the jest fix version release. cc @Greg-oliver99 @RoiEXLab |
@xiaoyuhen we can't do that. If we do, the project will only work with Jest v24+. I think we should wait a little before doing it. |
yeah, we need to wait until jest@24 is stable before considering support. If we consider supporting jest v24, maybe we need to release a 4.x version. The jest-puppeteer 3.x version supports jest v22~23, and the 4.x version supports jest v24+. |
@xiaoyuhen could you fix tests? I would like to release a new major this week with Jest 24 support. |
The travis-ci has this error
see https://travis-ci.org/smooth-code/jest-puppeteer/jobs/491494756#L515 Should we remove the support of node 9? |
@xiaoyuhen yeah, please add support only for node 8 & 10. v9 should not be used. |
Support for the jest v24 has been completed. If there are any suggestions, please let me know. |
Thanks! |
Sitting on edge for the npm publish, can't wait. ;) Thanks, for a nice package, soon I can run my tests again. |
Summary
Test plan
npm run test:incognito
running normally