Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Infinite loop in IE and Safari when using with Angular 2 #404

Closed
freezy opened this issue Oct 6, 2016 · 5 comments
Closed

Infinite loop in IE and Safari when using with Angular 2 #404

freezy opened this issue Oct 6, 2016 · 5 comments

Comments

@freezy
Copy link

freezy commented Oct 6, 2016

When using Smooch with Angular 2 and Webpack, the web application crashes due to an infinite loop. This happens when using Smooch as an npm dependency and also when including the minfied script tag in the body of the DOM.

In order reproduce, clone the official Angular 2 seed and add Smooch to it. Then run npm install && npm start and connect to http://localhost:3000 in Safari or IE. Chrome and Firefox work fine.

You will get a crash something along those lines:

SCRIPT28: Out of stack space
File: zone.js, Line: 385, Column: 18
SCRIPT2343: Stack overflow at line: 385
@lemieux
Copy link
Member

lemieux commented Oct 6, 2016

Thanks for the report, we'll look into it and we'll keep you posted. Could you provide which version of Safari and IE were having problems?

@freezy
Copy link
Author

freezy commented Oct 6, 2016

Thanks, IE 11.589.10586.0 and Safari 9.1.3.

@captaincole
Copy link

captaincole commented Nov 2, 2016

@lemieux any progress on this?

Adding some more context that I dug up. It seems that zone.js has an issue with any polyfill that tries and override its promise.

angular/zone.js#316 # #

Edit: I have found that its all about the order of your script imports in your index.html file. Add smooch.min.js last to avoid the issues.

@lemieux
Copy link
Member

lemieux commented Nov 4, 2016

@freezy can you try what @thielCole suggested in #416 ?

@lemieux
Copy link
Member

lemieux commented Dec 1, 2016

I'll close this since there's no activity for almost a month.

@lemieux lemieux closed this as completed Dec 1, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants