Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feature add: raw_arg #24

Closed
beckend opened this issue Sep 11, 2022 · 1 comment · Fixed by #32
Closed

feature add: raw_arg #24

beckend opened this issue Sep 11, 2022 · 1 comment · Fixed by #32

Comments

@beckend
Copy link

beckend commented Sep 11, 2022

This is needed for some arguments to work correctly on some commands:

https://doc.rust-lang.org/nightly/std/os/windows/process/trait.CommandExt.html#tymethod.raw_arg

related to: rust-lang/rust#29494
@taiki-e
Copy link
Collaborator

taiki-e commented Sep 12, 2022

Since windows_process_extensions_raw_arg was stabilized on Rust 1.62, I would accept a patch to support this on 1.62+ using the build script.

It would also be nice to do #6 at the same release, considering that the standard library has determined that sealing the CommandExt will not cause breakage (rust-lang/rust#81975).

@taiki-e taiki-e mentioned this issue Dec 30, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add windows::CommandExt::raw_arg on Rust 1.62+ smol-rs/async-process
2 participants
@beckend @taiki-e