Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[EN] Refactor parts of views.py & some templates #11

Open
1 of 5 tasks
JeS24 opened this issue Jul 23, 2023 · 5 comments
Open
1 of 5 tasks

[EN] Refactor parts of views.py & some templates #11

JeS24 opened this issue Jul 23, 2023 · 5 comments
Labels
backend backend related reports enhancement New feature or request good first issue Good for newcomers

Comments

@JeS24
Copy link
Collaborator

JeS24 commented Jul 23, 2023

Feature request / Suggestion

views.py and some templates require refactors to some parts. As more and more features were added (e.g., GSI, ARK), the files have become convoluted. These things should be refactored:

  • SignIn flow - _signin() function can probably be rolled into other functions.
  • status messages in responses (AJAX or otherwise) - We have many different status messages. Standardize or get rid of them, where possible.
  • information.html - DRY.
  • Templates like index.html may also be refactored.

Self-check
@JeS24 JeS24 added enhancement New feature or request good first issue Good for newcomers backend backend related reports labels Jul 23, 2023
@JeS24 JeS24 assigned JeS24 and unassigned JeS24 Jul 23, 2023
@JeS24 JeS24 pinned this issue Jul 29, 2023
@github-actions
Copy link

This issue is stale because it has been open for 60 days with no activity. Remove stale label or comment to re-open.

@JeS24 JeS24 reopened this Oct 1, 2023
@JeS24 JeS24 removed the stale-issue label Oct 1, 2023
@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 1, 2023

This issue is stale because it has been open for 60 days with no activity. Remove stale label or comment to re-open.

@JeS24 JeS24 removed the stale-issue label Dec 2, 2023
@github-actions GitHub Actions
Copy link

This issue is stale because it has been open for 60 days with no activity. Remove stale label or comment to re-open.

@JeS24 JeS24 removed the stale-issue label Feb 1, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Apr 1, 2024

This issue is stale because it has been open for 60 days with no activity. Remove stale label or comment to re-open.

@JeS24 JeS24 removed the stale-issue label Apr 6, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Jun 5, 2024

This issue is stale because it has been open for 60 days with no activity. Remove stale label or comment to re-open.

@JeS24 JeS24 removed the stale-issue label Jun 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
backend backend related reports enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@JeS24