New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Ec2Query Specification on response serialization #820

Closed

wooj2 opened this issue Jun 8, 2021 · 1 comment

Contributor

wooj2 commented Jun 8, 2021 •

edited

Loading

Observed behavior:

The Ec2Query Specification, located here: https://awslabs.github.io/smithy/1.0/spec/aws/aws-ec2-query-protocol.html#response-serialization, indicates "A nested element, with the name of the operation's output suffixed with "Result", contains the contents of the successful response."
When calling ec2 using the CLI w/ debug on, I am unable to observe a nested element suffixed with "Result".
For example:

aws ec2 describe-regions --debug

outputs:

2021-06-08 09:16:17,441 - MainThread - botocore.parsers - DEBUG - Response body:
b'<?xml version="1.0" encoding="UTF-8"?>
    <DescribeRegionsResponse xmlns="http://ec2.amazonaws.com/doc/2016-11-15/">
        <requestId>REDACTED</requestId>
            <regionInfo>
                <item>
                    <regionName>eu-north-1</regionName>
.... snip...

Expected Behavior

We should update:

The specification to remove the mention of a nested element
The sample response in the specification

It would be nice to update the specification to describe the RequestId

The text was updated successfully, but these errors were encountered:

wooj2 mentioned this issue

chore: ec2 avoid wrapping response awslabs/aws-sdk-swift#118

Merged

Member

mtdowling commented Jun 9, 2021

Fixed in #823

mtdowling closed this as completed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment