Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Increase support for the Accept header #1332

Closed
82marbag opened this issue Aug 9, 2022 · 2 comments
Closed

Increase support for the Accept header #1332

82marbag opened this issue Aug 9, 2022 · 2 comments
Labels
documentation This is a problem with documentation.

Comments

@82marbag
Copy link
Contributor

82marbag commented Aug 9, 2022

Some smithy clients and servers, such as in Typescript, allow the Accept header to reflect HTTP's spec, by allowing */* and type/*. The smithy spec allows neither of them.

After discussing this change, it was proposed to:

  • reflect the HTTP spec regarding the Accept header more closely, allowing *, but no q-factor weighting
  • servers should not use Accept to do protocol selection and allow them to respond in any of the allowed (by the header's value) ways
@82marbag
Copy link
Contributor Author

82marbag commented Aug 9, 2022

Related issue in smithy-rs, where we follow more closely the smithy spec: smithy-lang/smithy-rs#1544

This was referenced Aug 18, 2022
Merged
Merged
@mtdowling mtdowling added the documentation This is a problem with documentation. label Sep 5, 2022
@kstich
Copy link
Contributor

kstich commented Dec 9, 2022

Closed by #1365

@kstich kstich closed this as completed Dec 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
documentation This is a problem with documentation.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@mtdowling @kstich @82marbag