Change the release flow to use release branches #2253

LukeMathWalker · 2023-01-26T14:53:32Z

Releases will no longer happen on main, they'll be cut from dedicated release branches (one for each release series, e.g. 1.x.y or 0.5.x).

Each branch will have a CHANGELOG.md file (related to the changes in that release series) and a CHANGELOG.next.toml.
main will have the CHANGELOG.md with historical entries and the CHANGELOG.next.toml file with the changes that will go into the next release series.

The CHANGELOG.next.toml file on main is automatically cleaned up if a new release series is kicked off from the current HEAD of main. It will need to be manually cleaned up if a new release series series is kicked off from an older commit. I'm planning to remediate this in a follow-up PR (which will require the introduction of unique ids for each changelog entry, to be able to properly manipulate entries and be resistant to rewording/changes in the user-facing message).

All the required steps (creating the branch using a precise naming scheme, changing the runtime crates version in gradle.properties, tagging, publishing) will be handled by the updated release action.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

…properties?

github-actions · 2023-01-26T16:06:29Z

A new generated diff is ready to view.

A new doc preview is ready to view.

github-actions · 2023-01-26T18:59:27Z

A new generated diff is ready to view.

A new doc preview is ready to view.

github-actions · 2023-01-27T13:15:50Z

A new generated diff is ready to view.

A new doc preview is ready to view.

github-actions · 2023-01-27T14:16:42Z

A new generated diff is ready to view.

A new doc preview is ready to view.

github-actions · 2023-01-27T15:10:36Z

A new generated diff is ready to view.

A new doc preview is ready to view.

LukeMathWalker · 2023-01-30T12:15:44Z

tools/publisher/src/subcommand/generate_version_manifest.rs

+                // if unrecent_version > recent_version {
+                //     bail!(
+                //         "Version number for `{}` decreased between releases (from `{}` to `{}`)",
+                //         crate_name,
+                //         unrecent_version,
+                //         recent_version
+                //     );
+                // }


I had to comment this out since we are going from 0.54.1 to 0.0.0-smithy-rs-head on main - the version will only be set on release branches in gradle.properties.
If my understanding is correct, we can uncomment this (and the related test) after this PR has been merged.
@jdisanti @rcoh @Velfi @ysaito1001

You can just delete it.

Although, I think we might have another problem... The SDK release process always uses the latest versions.toml in the aws-sdk-rust repo root. If we want to do patch releases of the SDK, I think we'll have to do some modifications to that release process to have it use branches as well.

Yes, we'll need to do some changes there to be able to backport fixes for SDK crates.
I don't think changes will be necessary in order to do patch releases if they are the latest release (in the semver sense)?

Removed in f8de002

github-actions · 2023-02-01T11:14:05Z

A new generated diff is ready to view.

A new doc preview is ready to view.

github-actions · 2023-02-01T12:11:24Z

A new generated diff is ready to view.

A new doc preview is ready to view.

.github/scripts/get-or-create-release-branch.sh

david-perez · 2023-02-01T13:04:08Z

tools/publisher/src/subcommand/upgrade_runtime_crates_version.rs

+    let fs = Fs::Real;
+    let gradle_properties = read_gradle_properties(fs, &args.gradle_properties_path).await?;
+    let version_regex =
+        Regex::new(r"(?P<field>smithy\.rs\.runtime\.crate\.version=)(?P<version>\d+\.\d+\.\d+-.*)")


Isn't field always smithy.rs.runtime.crate.version=? Not sure why we're capturing it.

tools/publisher/src/subcommand/upgrade_runtime_crates_version.rs

david-perez · 2023-02-01T13:09:18Z

tools/publisher/src/subcommand/upgrade_runtime_crates_version.rs

+#[derive(Parser, Debug)]
+pub struct UpgradeRuntimeCratesVersionArgs {
+    /// The version of runtime crates you want the code generator to use (e.g. `0.52.0`).
+    #[clap(long)]


nit: Perhaps this should just be a positional arg, lest it be misconstrued as the version of a part of the CLI (?)

tools/publisher/src/subcommand/upgrade_runtime_crates_version.rs

Co-authored-by: david-perez <[email protected]>

github-actions · 2023-02-01T16:27:59Z

A new generated diff is ready to view.

A new doc preview is ready to view.

* What happens if we comment out the runtime crate version from gradle.properties? * Allow running the release and the CI workflows from an arbitrary commit. * Does a fake version work? * Pass `git_ref` from the release workflow. * It needs to be a valid semver version. * Sketch new command to upgrade version in gradle.properties * Command implementation * Plug the new publisher command into the `release` action. * Plumb end-to-end * Fix copyright header. * Fix lint. * Temporarily comment out the sanity check. * Ignore sanity check * Add a command that prints out the template for CHANGELOG.next.toml * Add branch check + empty TOML generation. * Add copyright headers. * Fix imports. * Remove sanity check. * Move script to a file. * Add a check to validate the tag. * Remove second build step. * Move to .github/scripts folder. * Make the script easier to run locally * Fail if anything fails. * Add comment. * Update .github/scripts/get-or-create-release-branch.sh Co-authored-by: david-perez <[email protected]> * Update .github/scripts/get-or-create-release-branch.sh Co-authored-by: david-perez <[email protected]> * Update .github/scripts/get-or-create-release-branch.sh Co-authored-by: david-perez <[email protected]> * Update .github/workflows/ci.yml Co-authored-by: david-perez <[email protected]> * Remove touch. * Fix indentation and branch name. * Update .github/workflows/ci.yml Co-authored-by: david-perez <[email protected]> * Update .github/workflows/release.yml Co-authored-by: david-perez <[email protected]> * Update .github/workflows/release.yml Co-authored-by: david-perez <[email protected]> * Explicit flags. * Use the path that was provided. * Format --------- Co-authored-by: david-perez <[email protected]>

* formatting: run pre-commit on all files (smithy-lang#2236) * formatting: run pre-commit on all files * fix: test broken by string indent * Remove old service builder machinery (smithy-lang#2161) * Remove HandlerGenerator and RegistryGenerator * Shrink RequestRejection * Remove inlineable * Remove Router and RequestParts * Remove old service builder tests * Add missing test dependency * Add missing dev dependency * Remove unused test * Move Router types * Switch AllowUnused to AllowUnusedVariables * Add changelog entry for "Remove old service builder machinery" (smithy-lang#2242) * Dense maps cannot deserialize null values (smithy-lang#2239) * Dense maps cannot deserialize null values Signed-off-by: Daniele Ahmed <[email protected]> * Dense lists cannot deserialize null (smithy-lang#2240) * Dense lists cannot deserialize null Signed-off-by: Daniele Ahmed <[email protected]> * Update changelog * Add changelog entry about smithy-lang#2200 (smithy-lang#2250) Co-authored-by: Julian Antonielli <[email protected]> * Fix `OperationExtensionFuture` poll order (smithy-lang#2247) * Fix `OperationExtensionFuture` poll order * Add CHANGELOG.next.toml entry Co-authored-by: AWS SDK Rust Bot <[email protected]> * Bump version to 0.54.1 in `gradle.properties` (smithy-lang#2249) Co-authored-by: Julian Antonielli <[email protected]> Co-authored-by: AWS SDK Rust Bot <[email protected]> * Update changelog * Add CI action to test aws-sdk-services (smithy-lang#2251) * run cargo test --all-features instead * Add check-only option, change check to test * Support nested APIs in operation input tests * Newtype FromRequest::Future (smithy-lang#2244) * Add RFC: Providing fallback credentials on timeout (smithy-lang#2218) * Add RFC: providing fallback credentials on timeout * Update design/src/rfcs/rfc0031_providing_fallback_credentials_on_timeout.md Co-authored-by: Zelda Hessler <[email protected]> * Update design/src/rfcs/rfc0031_providing_fallback_credentials_on_timeout.md Co-authored-by: Zelda Hessler <[email protected]> * Update design/src/rfcs/rfc0031_providing_fallback_credentials_on_timeout.md Co-authored-by: Zelda Hessler <[email protected]> * Update design/src/rfcs/rfc0031_providing_fallback_credentials_on_timeout.md Co-authored-by: Zelda Hessler <[email protected]> * Update design/src/rfcs/rfc0031_providing_fallback_credentials_on_timeout.md Co-authored-by: Zelda Hessler <[email protected]> * Update design/src/rfcs/rfc0031_providing_fallback_credentials_on_timeout.md Co-authored-by: Zelda Hessler <[email protected]> * Update design/src/rfcs/rfc0031_providing_fallback_credentials_on_timeout.md Co-authored-by: Zelda Hessler <[email protected]> * Update design/src/rfcs/rfc0031_providing_fallback_credentials_on_timeout.md Co-authored-by: Zelda Hessler <[email protected]> * Update design/src/rfcs/rfc0031_providing_fallback_credentials_on_timeout.md Co-authored-by: Zelda Hessler <[email protected]> * Update design/src/rfcs/rfc0031_providing_fallback_credentials_on_timeout.md Co-authored-by: Zelda Hessler <[email protected]> * Update design/src/rfcs/rfc0031_providing_fallback_credentials_on_timeout.md Co-authored-by: John DiSanti <[email protected]> * Incorporate review feedback into RFC This commit addresses the review feedback: smithy-lang#2218 (comment) smithy-lang#2218 (comment) smithy-lang#2218 (comment) In addition, we have renamed the proposed method `on_timeout` to `fallback_on_interrupt` to make it more descriptive. * Update rfc0031_providing_fallback_credentials_on_timeout.md * Update RFC This commit updates RFC and leaves to discussion how `fallback_on_interrupt` should be implemented, i.e., either as a synchronous primitive or an asynchronous primitive. * Update rfc0031_providing_fallback_credentials_on_timeout.md * Update rfc0031_providing_fallback_credentials_on_timeout.md * Update rfc0031_providing_fallback_credentials_on_timeout.md --------- Co-authored-by: Yuki Saito <[email protected]> Co-authored-by: Zelda Hessler <[email protected]> Co-authored-by: John DiSanti <[email protected]> Co-authored-by: Luca Palmieri <[email protected]> * Replace PR bot's diff tool with one that supports pagination (smithy-lang#2245) * Implement paginated diff to html tool * Wire up the new diff tool to PR bot * Add fallback_on_interrupt to the ProvideCredentials trait (smithy-lang#2246) * Implement RFC for providing fallback credentials This commit implements the changes checklist in the RFC for providing fallback credentials. * Remove needless lifetime parameter * Update CHANGELOG.next.toml --------- Co-authored-by: Yuki Saito <[email protected]> * Copy non-service integration tests into SDK root tests directory (smithy-lang#2255) * Copy non-service integration tests into SDK root tests directory For tests in `aws/sdk/integration-tests` that are not named after a service module, copy them into the SDK's root `tests/` directory so that they are run as part of CI on the entire SDK. * Add missing fields to integration test manifests * Remove tests from root workspace * Explicitly exclude the root tests from the root workspace * Update the event stream section in RFC30 (smithy-lang#2243) * Python: Support `document` type (smithy-lang#2188) * Add Python wrapper for `aws_smithy_types::Document` * Remove unused type * Make sure Python SSDKs uses Python specific `Document` type * Allow Python specific `Document` type to be used in serialization and deserialization * Make `pyo3/extension-module` a default feature * Add `PythonServerTypesTest` * Fix linting issues * Add `Data limit exceeded` to build image throttle messages (smithy-lang#2260) * Update smoketest models (smithy-lang#2252) * Make minor fixes to the crate claim workflow (smithy-lang#2259) * Add support for `@uniqueItems` (smithy-lang#2232) This commit adds support for the `@uniqueItems` trait on `list` shapes in server SDKs. Requests with duplicate values for `list` shapes constrained with `@uniqueItems` will be rejected by servers. * Update mentions to codegen configuration key in changelog (smithy-lang#2166) As well as in one error message. The key is `codegen`, not `codegenConfig`. * Change the release flow to use release branches (smithy-lang#2253) * What happens if we comment out the runtime crate version from gradle.properties? * Allow running the release and the CI workflows from an arbitrary commit. * Does a fake version work? * Pass `git_ref` from the release workflow. * It needs to be a valid semver version. * Sketch new command to upgrade version in gradle.properties * Command implementation * Plug the new publisher command into the `release` action. * Plumb end-to-end * Fix copyright header. * Fix lint. * Temporarily comment out the sanity check. * Ignore sanity check * Add a command that prints out the template for CHANGELOG.next.toml * Add branch check + empty TOML generation. * Add copyright headers. * Fix imports. * Remove sanity check. * Move script to a file. * Add a check to validate the tag. * Remove second build step. * Move to .github/scripts folder. * Make the script easier to run locally * Fail if anything fails. * Add comment. * Update .github/scripts/get-or-create-release-branch.sh Co-authored-by: david-perez <[email protected]> * Update .github/scripts/get-or-create-release-branch.sh Co-authored-by: david-perez <[email protected]> * Update .github/scripts/get-or-create-release-branch.sh Co-authored-by: david-perez <[email protected]> * Update .github/workflows/ci.yml Co-authored-by: david-perez <[email protected]> * Remove touch. * Fix indentation and branch name. * Update .github/workflows/ci.yml Co-authored-by: david-perez <[email protected]> * Update .github/workflows/release.yml Co-authored-by: david-perez <[email protected]> * Update .github/workflows/release.yml Co-authored-by: david-perez <[email protected]> * Explicit flags. * Use the path that was provided. * Format --------- Co-authored-by: david-perez <[email protected]> * Reduce Docker image rebuilds (smithy-lang#2269) * Move `acquire-build-image` into `.github` * Move the `tools-hash` script into `.github` * Upload to ECR from PRs as well * Move build tools into `tools/ci-build/` * Move CI scripts out of `ci-build` * Split CI for forks/non-forks * Remove `fetch-depth: 0` from PR workflows * Remove teams from `publisher` ownership list (smithy-lang#2257) * Add static stability support to IMDS credentials provider (smithy-lang#2258) * Add static stability support to ImdsCredentialsProvider This commit adds static stability support to `ImdsCredentialsProvider`. Static stability refers to continued availability of a service in the face of impaired dependencies. In case IMDS is not available, we still allow requests to be dispatched with expired credentials. This, in turn, allows the target service to makes the ultimate decision as to whether requests sent are valid or not instead of the client SDK determining their validity. The way it is implemented is `ImdsCredentialsProvider` now stores a last retrieved credentials which will later be served when IMDS is unreachable. * Add tests to IMDS credentials provider This commit adds tests to IMDS credentials providers for static stability support. These tests are prescribed in smithy-lang#2117. From an IMDS credentials provider' perspective, however, some of the tests are considered to fall under the same equivalence class with others. Therefore, a single test can cover multiple test cases. * Update CHANGELOG.next.toml * Update CHANGELOG.next.toml Co-authored-by: John DiSanti <[email protected]> --------- Co-authored-by: Yuki Saito <[email protected]> Co-authored-by: John DiSanti <[email protected]> * Increase build image backoff time and attempts (smithy-lang#2267) * Must set a member in unions (smithy-lang#2241) * Must set a member in unions Signed-off-by: Daniele Ahmed <[email protected]> * Add `runs-on` (smithy-lang#2273) * Add `runs-on` (smithy-lang#2275) * Fix job trigger. Clarify that short SHAs won't work. (smithy-lang#2278) * Clarify what type of reference we are trying to push. (smithy-lang#2279) * Update gradle properties for dry runs as well. (smithy-lang#2280) * Get verbose logging from the branch script. (smithy-lang#2281) * Fix trigger for following jobs. (smithy-lang#2282) * Fix action paths. (smithy-lang#2283) * We need to checkout in the `smithy-rs` folder because that's an assumption baked into the definition of the docker-build action. (smithy-lang#2284) * Use action-arguments for arguments. (smithy-lang#2285) * Fix if condition. (smithy-lang#2286) * Persist the modified gradle.properties outside of the Docker context (smithy-lang#2287) * Fix if condition. * Make sure that the changes are visible to the push step after the Docker action has executed by persisting the modified repository as an artifact. * Give a name to the argument. * Use larger machines for the slowest CI jobs. (smithy-lang#2263) * Use larger machines for the slowest CI jobs. * Fix invocation. * Fix paths. (smithy-lang#2288) * Commit if modified (smithy-lang#2289) * Fix paths. * Fix commit logic - it should commit when there were changes. * Set user name and email when committing (smithy-lang#2290) * `git push origin` fails if there is nothing to push. (smithy-lang#2291) * Use curly braces to group together the commit and push action (smithy-lang#2292) * Fix syntax error when grouping commands. (smithy-lang#2293) * [release-branches] Fix the reference that gets checked out (smithy-lang#2294) * Fix the reference that gets checked out * Fix * Fix broken doc link to `tokio_stream::Stream` (smithy-lang#2271) * Fix broken doc link to `Stream` This commit fixes broken doc link to `Stream` in codegen clients. That target is `tokio_stream::Stream`, which in turn is a re-export of `futures_core::Stream`. Since we do not have a good way to link to the re-export, we remove a hyper link and just put `Stream`. * Update CHANGELOG.next.toml --------- Co-authored-by: Yuki Saito <[email protected]> * Use docker login when possible (smithy-lang#2265) Login to ECR when credentials are available to improve CI performance * Simplify `AdHocSection` (smithy-lang#2272) Co-authored-by: Russell Cohen <[email protected]> * Fix CI on main and don't acquire Docker login for forks (smithy-lang#2295) * Fix CI on main and don't acquire Docker login for forks * Convert empty env vars into `None` * Optimize base image acquisition on main * Collect more diagnostics. (smithy-lang#2297) * [release-branches] Fix working directory (smithy-lang#2298) * Fix working directory. * Build the Docker image using the latest commit on the invocation branch. * We need a Docker image with the same SHA later in the process. * Clone does not preserve uncommitted changes. This was leading to the gradle.properties update being lost. (smithy-lang#2299) * Make `OperationExtension` store the absolute shape ID (smithy-lang#2276) * Do not alter Operation shape ID * Add OperationExtensionExt test * Add CHANGELOG.next.toml entry * Apply suggestions from code review Co-authored-by: Luca Palmieri <[email protected]> --------- Co-authored-by: Luca Palmieri <[email protected]> * Retrieve the output from outside the Docker context (smithy-lang#2300) Co-authored-by: AWS SDK Rust Bot <[email protected]> * Fix image tagging in CI on main (smithy-lang#2301) * Fix handling of repeated headers in AWS request canonicalization (smithy-lang#2261) * Remove usage of always empty writable in `JsonParserGenerator` (smithy-lang#2192) The writable calculates a string that it never writes. This was added in smithy-lang#2131. * fix --------- Signed-off-by: Daniele Ahmed <[email protected]> Co-authored-by: Zelda Hessler <[email protected]> Co-authored-by: Harry Barber <[email protected]> Co-authored-by: 82marbag <[email protected]> Co-authored-by: AWS SDK Rust Bot <[email protected]> Co-authored-by: Julian Antonielli <[email protected]> Co-authored-by: Julian Antonielli <[email protected]> Co-authored-by: AWS SDK Rust Bot <[email protected]> Co-authored-by: Russell Cohen <[email protected]> Co-authored-by: ysaito1001 <[email protected]> Co-authored-by: Yuki Saito <[email protected]> Co-authored-by: John DiSanti <[email protected]> Co-authored-by: Luca Palmieri <[email protected]> Co-authored-by: Burak <[email protected]> Co-authored-by: david-perez <[email protected]> Co-authored-by: Nipunn Koorapati <[email protected]>

* formatting: run pre-commit on all files (smithy-lang#2236) * formatting: run pre-commit on all files * fix: test broken by string indent * Remove old service builder machinery (smithy-lang#2161) * Remove HandlerGenerator and RegistryGenerator * Shrink RequestRejection * Remove inlineable * Remove Router and RequestParts * Remove old service builder tests * Add missing test dependency * Add missing dev dependency * Remove unused test * Move Router types * Switch AllowUnused to AllowUnusedVariables * Add changelog entry for "Remove old service builder machinery" (smithy-lang#2242) * Dense maps cannot deserialize null values (smithy-lang#2239) * Dense maps cannot deserialize null values Signed-off-by: Daniele Ahmed <[email protected]> * Dense lists cannot deserialize null (smithy-lang#2240) * Dense lists cannot deserialize null Signed-off-by: Daniele Ahmed <[email protected]> * Update changelog * Add changelog entry about smithy-lang#2200 (smithy-lang#2250) Co-authored-by: Julian Antonielli <[email protected]> * Fix `OperationExtensionFuture` poll order (smithy-lang#2247) * Fix `OperationExtensionFuture` poll order * Add CHANGELOG.next.toml entry Co-authored-by: AWS SDK Rust Bot <[email protected]> * Bump version to 0.54.1 in `gradle.properties` (smithy-lang#2249) Co-authored-by: Julian Antonielli <[email protected]> Co-authored-by: AWS SDK Rust Bot <[email protected]> * Update changelog * Add CI action to test aws-sdk-services (smithy-lang#2251) * run cargo test --all-features instead * Add check-only option, change check to test * Support nested APIs in operation input tests * Newtype FromRequest::Future (smithy-lang#2244) * Add RFC: Providing fallback credentials on timeout (smithy-lang#2218) * Add RFC: providing fallback credentials on timeout * Update design/src/rfcs/rfc0031_providing_fallback_credentials_on_timeout.md Co-authored-by: Zelda Hessler <[email protected]> * Update design/src/rfcs/rfc0031_providing_fallback_credentials_on_timeout.md Co-authored-by: Zelda Hessler <[email protected]> * Update design/src/rfcs/rfc0031_providing_fallback_credentials_on_timeout.md Co-authored-by: Zelda Hessler <[email protected]> * Update design/src/rfcs/rfc0031_providing_fallback_credentials_on_timeout.md Co-authored-by: Zelda Hessler <[email protected]> * Update design/src/rfcs/rfc0031_providing_fallback_credentials_on_timeout.md Co-authored-by: Zelda Hessler <[email protected]> * Update design/src/rfcs/rfc0031_providing_fallback_credentials_on_timeout.md Co-authored-by: Zelda Hessler <[email protected]> * Update design/src/rfcs/rfc0031_providing_fallback_credentials_on_timeout.md Co-authored-by: Zelda Hessler <[email protected]> * Update design/src/rfcs/rfc0031_providing_fallback_credentials_on_timeout.md Co-authored-by: Zelda Hessler <[email protected]> * Update design/src/rfcs/rfc0031_providing_fallback_credentials_on_timeout.md Co-authored-by: Zelda Hessler <[email protected]> * Update design/src/rfcs/rfc0031_providing_fallback_credentials_on_timeout.md Co-authored-by: Zelda Hessler <[email protected]> * Update design/src/rfcs/rfc0031_providing_fallback_credentials_on_timeout.md Co-authored-by: John DiSanti <[email protected]> * Incorporate review feedback into RFC This commit addresses the review feedback: smithy-lang#2218 (comment) smithy-lang#2218 (comment) smithy-lang#2218 (comment) In addition, we have renamed the proposed method `on_timeout` to `fallback_on_interrupt` to make it more descriptive. * Update rfc0031_providing_fallback_credentials_on_timeout.md * Update RFC This commit updates RFC and leaves to discussion how `fallback_on_interrupt` should be implemented, i.e., either as a synchronous primitive or an asynchronous primitive. * Update rfc0031_providing_fallback_credentials_on_timeout.md * Update rfc0031_providing_fallback_credentials_on_timeout.md * Update rfc0031_providing_fallback_credentials_on_timeout.md --------- Co-authored-by: Yuki Saito <[email protected]> Co-authored-by: Zelda Hessler <[email protected]> Co-authored-by: John DiSanti <[email protected]> Co-authored-by: Luca Palmieri <[email protected]> * Replace PR bot's diff tool with one that supports pagination (smithy-lang#2245) * Implement paginated diff to html tool * Wire up the new diff tool to PR bot * Add fallback_on_interrupt to the ProvideCredentials trait (smithy-lang#2246) * Implement RFC for providing fallback credentials This commit implements the changes checklist in the RFC for providing fallback credentials. * Remove needless lifetime parameter * Update CHANGELOG.next.toml --------- Co-authored-by: Yuki Saito <[email protected]> * Copy non-service integration tests into SDK root tests directory (smithy-lang#2255) * Copy non-service integration tests into SDK root tests directory For tests in `aws/sdk/integration-tests` that are not named after a service module, copy them into the SDK's root `tests/` directory so that they are run as part of CI on the entire SDK. * Add missing fields to integration test manifests * Remove tests from root workspace * Explicitly exclude the root tests from the root workspace * Update the event stream section in RFC30 (smithy-lang#2243) * Python: Support `document` type (smithy-lang#2188) * Add Python wrapper for `aws_smithy_types::Document` * Remove unused type * Make sure Python SSDKs uses Python specific `Document` type * Allow Python specific `Document` type to be used in serialization and deserialization * Make `pyo3/extension-module` a default feature * Add `PythonServerTypesTest` * Fix linting issues * Add `Data limit exceeded` to build image throttle messages (smithy-lang#2260) * Update smoketest models (smithy-lang#2252) * Make minor fixes to the crate claim workflow (smithy-lang#2259) * Add support for `@uniqueItems` (smithy-lang#2232) This commit adds support for the `@uniqueItems` trait on `list` shapes in server SDKs. Requests with duplicate values for `list` shapes constrained with `@uniqueItems` will be rejected by servers. * Update mentions to codegen configuration key in changelog (smithy-lang#2166) As well as in one error message. The key is `codegen`, not `codegenConfig`. * Change the release flow to use release branches (smithy-lang#2253) * What happens if we comment out the runtime crate version from gradle.properties? * Allow running the release and the CI workflows from an arbitrary commit. * Does a fake version work? * Pass `git_ref` from the release workflow. * It needs to be a valid semver version. * Sketch new command to upgrade version in gradle.properties * Command implementation * Plug the new publisher command into the `release` action. * Plumb end-to-end * Fix copyright header. * Fix lint. * Temporarily comment out the sanity check. * Ignore sanity check * Add a command that prints out the template for CHANGELOG.next.toml * Add branch check + empty TOML generation. * Add copyright headers. * Fix imports. * Remove sanity check. * Move script to a file. * Add a check to validate the tag. * Remove second build step. * Move to .github/scripts folder. * Make the script easier to run locally * Fail if anything fails. * Add comment. * Update .github/scripts/get-or-create-release-branch.sh Co-authored-by: david-perez <[email protected]> * Update .github/scripts/get-or-create-release-branch.sh Co-authored-by: david-perez <[email protected]> * Update .github/scripts/get-or-create-release-branch.sh Co-authored-by: david-perez <[email protected]> * Update .github/workflows/ci.yml Co-authored-by: david-perez <[email protected]> * Remove touch. * Fix indentation and branch name. * Update .github/workflows/ci.yml Co-authored-by: david-perez <[email protected]> * Update .github/workflows/release.yml Co-authored-by: david-perez <[email protected]> * Update .github/workflows/release.yml Co-authored-by: david-perez <[email protected]> * Explicit flags. * Use the path that was provided. * Format --------- Co-authored-by: david-perez <[email protected]> * Reduce Docker image rebuilds (smithy-lang#2269) * Move `acquire-build-image` into `.github` * Move the `tools-hash` script into `.github` * Upload to ECR from PRs as well * Move build tools into `tools/ci-build/` * Move CI scripts out of `ci-build` * Split CI for forks/non-forks * Remove `fetch-depth: 0` from PR workflows * Remove teams from `publisher` ownership list (smithy-lang#2257) * Add static stability support to IMDS credentials provider (smithy-lang#2258) * Add static stability support to ImdsCredentialsProvider This commit adds static stability support to `ImdsCredentialsProvider`. Static stability refers to continued availability of a service in the face of impaired dependencies. In case IMDS is not available, we still allow requests to be dispatched with expired credentials. This, in turn, allows the target service to makes the ultimate decision as to whether requests sent are valid or not instead of the client SDK determining their validity. The way it is implemented is `ImdsCredentialsProvider` now stores a last retrieved credentials which will later be served when IMDS is unreachable. * Add tests to IMDS credentials provider This commit adds tests to IMDS credentials providers for static stability support. These tests are prescribed in smithy-lang#2117. From an IMDS credentials provider' perspective, however, some of the tests are considered to fall under the same equivalence class with others. Therefore, a single test can cover multiple test cases. * Update CHANGELOG.next.toml * Update CHANGELOG.next.toml Co-authored-by: John DiSanti <[email protected]> --------- Co-authored-by: Yuki Saito <[email protected]> Co-authored-by: John DiSanti <[email protected]> * Increase build image backoff time and attempts (smithy-lang#2267) * Must set a member in unions (smithy-lang#2241) * Must set a member in unions Signed-off-by: Daniele Ahmed <[email protected]> * Add `runs-on` (smithy-lang#2273) * Add `runs-on` (smithy-lang#2275) * Fix job trigger. Clarify that short SHAs won't work. (smithy-lang#2278) * Clarify what type of reference we are trying to push. (smithy-lang#2279) * Update gradle properties for dry runs as well. (smithy-lang#2280) * Get verbose logging from the branch script. (smithy-lang#2281) * Fix trigger for following jobs. (smithy-lang#2282) * Fix action paths. (smithy-lang#2283) * We need to checkout in the `smithy-rs` folder because that's an assumption baked into the definition of the docker-build action. (smithy-lang#2284) * Use action-arguments for arguments. (smithy-lang#2285) * Fix if condition. (smithy-lang#2286) * Persist the modified gradle.properties outside of the Docker context (smithy-lang#2287) * Fix if condition. * Make sure that the changes are visible to the push step after the Docker action has executed by persisting the modified repository as an artifact. * Give a name to the argument. * Use larger machines for the slowest CI jobs. (smithy-lang#2263) * Use larger machines for the slowest CI jobs. * Fix invocation. * Fix paths. (smithy-lang#2288) * Commit if modified (smithy-lang#2289) * Fix paths. * Fix commit logic - it should commit when there were changes. * Set user name and email when committing (smithy-lang#2290) * `git push origin` fails if there is nothing to push. (smithy-lang#2291) * Use curly braces to group together the commit and push action (smithy-lang#2292) * Fix syntax error when grouping commands. (smithy-lang#2293) * [release-branches] Fix the reference that gets checked out (smithy-lang#2294) * Fix the reference that gets checked out * Fix * Fix broken doc link to `tokio_stream::Stream` (smithy-lang#2271) * Fix broken doc link to `Stream` This commit fixes broken doc link to `Stream` in codegen clients. That target is `tokio_stream::Stream`, which in turn is a re-export of `futures_core::Stream`. Since we do not have a good way to link to the re-export, we remove a hyper link and just put `Stream`. * Update CHANGELOG.next.toml --------- Co-authored-by: Yuki Saito <[email protected]> * Use docker login when possible (smithy-lang#2265) Login to ECR when credentials are available to improve CI performance * Simplify `AdHocSection` (smithy-lang#2272) Co-authored-by: Russell Cohen <[email protected]> * Fix CI on main and don't acquire Docker login for forks (smithy-lang#2295) * Fix CI on main and don't acquire Docker login for forks * Convert empty env vars into `None` * Optimize base image acquisition on main * Collect more diagnostics. (smithy-lang#2297) * [release-branches] Fix working directory (smithy-lang#2298) * Fix working directory. * Build the Docker image using the latest commit on the invocation branch. * We need a Docker image with the same SHA later in the process. * Clone does not preserve uncommitted changes. This was leading to the gradle.properties update being lost. (smithy-lang#2299) * Make `OperationExtension` store the absolute shape ID (smithy-lang#2276) * Do not alter Operation shape ID * Add OperationExtensionExt test * Add CHANGELOG.next.toml entry * Apply suggestions from code review Co-authored-by: Luca Palmieri <[email protected]> --------- Co-authored-by: Luca Palmieri <[email protected]> * Retrieve the output from outside the Docker context (smithy-lang#2300) Co-authored-by: AWS SDK Rust Bot <[email protected]> * Fix image tagging in CI on main (smithy-lang#2301) * Fix handling of repeated headers in AWS request canonicalization (smithy-lang#2261) * Remove usage of always empty writable in `JsonParserGenerator` (smithy-lang#2192) The writable calculates a string that it never writes. This was added in smithy-lang#2131. --------- Signed-off-by: Daniele Ahmed <[email protected]> Co-authored-by: Zelda Hessler <[email protected]> Co-authored-by: Harry Barber <[email protected]> Co-authored-by: 82marbag <[email protected]> Co-authored-by: AWS SDK Rust Bot <[email protected]> Co-authored-by: Julian Antonielli <[email protected]> Co-authored-by: Julian Antonielli <[email protected]> Co-authored-by: AWS SDK Rust Bot <[email protected]> Co-authored-by: Russell Cohen <[email protected]> Co-authored-by: ysaito1001 <[email protected]> Co-authored-by: Yuki Saito <[email protected]> Co-authored-by: John DiSanti <[email protected]> Co-authored-by: Luca Palmieri <[email protected]> Co-authored-by: Burak <[email protected]> Co-authored-by: david-perez <[email protected]> Co-authored-by: Nipunn Koorapati <[email protected]>

LukeMathWalker added 5 commits January 26, 2023 14:51

What happens if we comment out the runtime crate version from gradle.…

ca22c78

…properties?

Allow running the release and the CI workflows from an arbitrary commit.

1d045ea

Does a fake version work?

37bc560

Pass git_ref from the release workflow.

a8a6ff2

It needs to be a valid semver version.

219f125

LukeMathWalker added 2 commits January 26, 2023 18:14

Sketch new command to upgrade version in gradle.properties

9394c6b

Command implementation

6ee191d

Plug the new publisher command into the release action.

9d997d1

LukeMathWalker added 4 commits January 27, 2023 13:16

Plumb end-to-end

8a8713a

Fix copyright header.

9cadab2

Fix lint.

93dcf7b

Temporarily comment out the sanity check.

d163264

Ignore sanity check

91b2978

LukeMathWalker added 2 commits January 30, 2023 11:40

Add a command that prints out the template for CHANGELOG.next.toml

63b3a56

Add branch check + empty TOML generation.

aa2a7eb

LukeMathWalker changed the title ~~Patch experiments~~ Change the release flow to use release branches Jan 30, 2023

LukeMathWalker marked this pull request as ready for review January 30, 2023 12:14

LukeMathWalker requested review from a team as code owners January 30, 2023 12:14

LukeMathWalker requested review from drganjoo and weihanglo January 30, 2023 12:14

LukeMathWalker commented Jan 30, 2023

View reviewed changes

LukeMathWalker added needs-sdk-review needs-server-review labels Jan 30, 2023

Merge branch 'main' into patches

cfea8dc

LukeMathWalker added this to the Server GA milestone Feb 1, 2023

Move to .github/scripts folder.

815ffc5

LukeMathWalker removed the needs-sdk-review label Feb 1, 2023

LukeMathWalker added 3 commits February 1, 2023 11:15

Make the script easier to run locally

4851010

Fail if anything fails.

a439fc5

Add comment.

a318f04

david-perez approved these changes Feb 1, 2023

View reviewed changes

david-perez removed the needs-server-review label Feb 1, 2023

LukeMathWalker and others added 13 commits February 1, 2023 15:23

Update .github/scripts/get-or-create-release-branch.sh

42fc4fb

Co-authored-by: david-perez <[email protected]>

Update .github/scripts/get-or-create-release-branch.sh

7751de1

Co-authored-by: david-perez <[email protected]>

Update .github/scripts/get-or-create-release-branch.sh

3a52ed7

Co-authored-by: david-perez <[email protected]>

Update .github/workflows/ci.yml

0414cce

Co-authored-by: david-perez <[email protected]>

Remove touch.

e3c0bc2

Fix indentation and branch name.

9a739ba

Update .github/workflows/ci.yml

c95e895

Co-authored-by: david-perez <[email protected]>

Update .github/workflows/release.yml

b7dab07

Co-authored-by: david-perez <[email protected]>

Update .github/workflows/release.yml

53bb4cc

Co-authored-by: david-perez <[email protected]>

Explicit flags.

7806c72

Use the path that was provided.

62e0518

Format

2526b89

Merge branch 'main' into patches

5b2fa2b

LukeMathWalker enabled auto-merge (squash) February 1, 2023 17:08

LukeMathWalker merged commit d9c0b2e into main Feb 1, 2023

LukeMathWalker deleted the patches branch February 1, 2023 17:10

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Change the release flow to use release branches #2253

Change the release flow to use release branches #2253

LukeMathWalker commented Jan 26, 2023 •

edited

Loading

github-actions bot commented Jan 26, 2023

github-actions bot commented Jan 26, 2023

github-actions bot commented Jan 27, 2023

github-actions bot commented Jan 27, 2023

github-actions bot commented Jan 27, 2023

LukeMathWalker Jan 30, 2023

jdisanti Jan 30, 2023

jdisanti Jan 30, 2023

LukeMathWalker Jan 30, 2023

LukeMathWalker Jan 31, 2023

github-actions bot commented Feb 1, 2023

github-actions bot commented Feb 1, 2023

david-perez Feb 1, 2023

david-perez Feb 1, 2023

github-actions bot commented Feb 1, 2023

Change the release flow to use release branches #2253

Change the release flow to use release branches #2253

Conversation

LukeMathWalker commented Jan 26, 2023 • edited Loading

github-actions bot commented Jan 26, 2023

github-actions bot commented Jan 26, 2023

github-actions bot commented Jan 27, 2023

github-actions bot commented Jan 27, 2023

github-actions bot commented Jan 27, 2023

LukeMathWalker Jan 30, 2023

Choose a reason for hiding this comment

jdisanti Jan 30, 2023

Choose a reason for hiding this comment

jdisanti Jan 30, 2023

Choose a reason for hiding this comment

LukeMathWalker Jan 30, 2023

Choose a reason for hiding this comment

LukeMathWalker Jan 31, 2023

Choose a reason for hiding this comment

github-actions bot commented Feb 1, 2023

github-actions bot commented Feb 1, 2023

david-perez Feb 1, 2023

Choose a reason for hiding this comment

david-perez Feb 1, 2023

Choose a reason for hiding this comment

github-actions bot commented Feb 1, 2023

LukeMathWalker commented Jan 26, 2023 •

edited

Loading