From 5ffda0be00ec233b8457500af553fd94b4ad7cfe Mon Sep 17 00:00:00 2001 From: Michael Choi Date: Tue, 25 Jan 2022 22:17:43 +0000 Subject: [PATCH 1/3] Provide SigningService creation via owned String (#1114) --- CHANGELOG.next.toml | 25 +++---------------------- aws/rust-runtime/aws-types/src/lib.rs | 6 ++++++ 2 files changed, 9 insertions(+), 22 deletions(-) diff --git a/CHANGELOG.next.toml b/CHANGELOG.next.toml index 25686931de..6889693f02 100644 --- a/CHANGELOG.next.toml +++ b/CHANGELOG.next.toml @@ -1,24 +1,5 @@ -# Example changelog entries -# [[aws-sdk-rust]] -# message = "Fix typos in module documentation for generated crates" -# references = ["smithy-rs#920"] -# meta = { "breaking" = false, "tada" = false, "bug" = false } -# author = "rcoh" -# -# [[smithy-rs]] -# message = "Fix typos in module documentation for generated crates" -# references = ["smithy-rs#920"] -# meta = { "breaking" = false, "tada" = false, "bug" = false } -# author = "rcoh" - -[[aws-sdk-rust]] -message = "Convert several `info` spans to `debug` in aws-config" -references = ["smithy-rs#1087"] -meta = { "breaking" = false, "tada" = false, "bug" = false } -author = "rcoh" - [[smithy-rs]] -message = "Improve docs on `Endpoint::{mutable, immutable}`" -references = ["smithy-rs#1087"] +message = "Provide SigningService creation via owned String" +references = ["smithy-rs#1114"] meta = { "breaking" = false, "tada" = false, "bug" = false } -author = "rcoh" \ No newline at end of file +author = "mchoicpe-amazon" \ No newline at end of file diff --git a/aws/rust-runtime/aws-types/src/lib.rs b/aws/rust-runtime/aws-types/src/lib.rs index 3421b5f2e2..eb39142feb 100644 --- a/aws/rust-runtime/aws-types/src/lib.rs +++ b/aws/rust-runtime/aws-types/src/lib.rs @@ -42,3 +42,9 @@ impl SigningService { SigningService(Cow::Borrowed(service)) } } + +impl From for SigningService { + fn from(service: String) -> Self { + SigningService(Cow::Owned(service)) + } +} From 35d144300880d76b0e651170f52f9c51e2fd3b54 Mon Sep 17 00:00:00 2001 From: Michael Choi Date: Tue, 25 Jan 2022 22:29:25 +0000 Subject: [PATCH 2/3] Correct CHANGELOG.next.toml to include previous changes --- CHANGELOG.next.toml | 27 ++++++++++++++++++++++++++- 1 file changed, 26 insertions(+), 1 deletion(-) diff --git a/CHANGELOG.next.toml b/CHANGELOG.next.toml index 6889693f02..c7c7c566cf 100644 --- a/CHANGELOG.next.toml +++ b/CHANGELOG.next.toml @@ -1,5 +1,30 @@ +# Example changelog entries +# [[aws-sdk-rust]] +# message = "Fix typos in module documentation for generated crates" +# references = ["smithy-rs#920"] +# meta = { "breaking" = false, "tada" = false, "bug" = false } +# author = "rcoh" +# +# [[smithy-rs]] +# message = "Fix typos in module documentation for generated crates" +# references = ["smithy-rs#920"] +# meta = { "breaking" = false, "tada" = false, "bug" = false } +# author = "rcoh" + +[[aws-sdk-rust]] +message = "Convert several `info` spans to `debug` in aws-config" +references = ["smithy-rs#1087"] +meta = { "breaking" = false, "tada" = false, "bug" = false } +author = "rcoh" + +[[smithy-rs]] +message = "Improve docs on `Endpoint::{mutable, immutable}`" +references = ["smithy-rs#1087"] +meta = { "breaking" = false, "tada" = false, "bug" = false } +author = "rcoh" + [[smithy-rs]] message = "Provide SigningService creation via owned String" references = ["smithy-rs#1114"] meta = { "breaking" = false, "tada" = false, "bug" = false } -author = "mchoicpe-amazon" \ No newline at end of file +author = "mchoicpe-amazon" From 42a80abf6820cd09495d4a4afcf7862133f6a0ef Mon Sep 17 00:00:00 2001 From: Michael Choi Date: Tue, 25 Jan 2022 22:47:18 +0000 Subject: [PATCH 3/3] Fetch and merge changes from CHANGELOG.next.toml --- CHANGELOG.next.toml | 12 ++++++++++++ 1 file changed, 12 insertions(+) diff --git a/CHANGELOG.next.toml b/CHANGELOG.next.toml index c7c7c566cf..f044289202 100644 --- a/CHANGELOG.next.toml +++ b/CHANGELOG.next.toml @@ -23,6 +23,18 @@ references = ["smithy-rs#1087"] meta = { "breaking" = false, "tada" = false, "bug" = false } author = "rcoh" +[[aws-sdk-rust]] +message = "SDK examples now come from [`awsdocs/aws-doc-sdk-examples`](https://github.com/awsdocs/aws-doc-sdk-examples) rather than from `smithy-rs`" +references = ["smithy-rs#1118"] +meta = { "breaking" = false, "tada" = false, "bug" = false } +author = "jdisanti" + +[[smithy-rs]] +message = "SDK examples now come from [`awsdocs/aws-doc-sdk-examples`](https://github.com/awsdocs/aws-doc-sdk-examples) rather than from `smithy-rs`" +references = ["smithy-rs#1118"] +meta = { "breaking" = false, "tada" = false, "bug" = false } +author = "jdisanti" + [[smithy-rs]] message = "Provide SigningService creation via owned String" references = ["smithy-rs#1114"]