Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove doc[hidden] aliases from codegen #976

Closed
rcoh opened this issue Dec 14, 2021 · 1 comment
Closed

remove doc[hidden] aliases from codegen #976

rcoh opened this issue Dec 14, 2021 · 1 comment
Assignees
Milestone

Comments

@rcoh
Copy link
Collaborator

rcoh commented Dec 14, 2021

To pass information through between the operations and the fluent builders, pub types are created: https://github.com/awslabs/smithy-rs/blob/25def3a61287a126157d500829d5aff689e26ec4/codegen/src/main/kotlin/software/amazon/smithy/rust/codegen/smithy/generators/protocol/ProtocolGenerator.kt#L246-L251

These are doc(hidden) and public. We should remove them, the have confused customers.

@rcoh rcoh added this to the GA milestone Dec 14, 2021
@Velfi Velfi self-assigned this Sep 6, 2022
@Velfi
Copy link
Contributor

Velfi commented Sep 26, 2022

released as part of v0.49.0

@Velfi Velfi closed this as completed Sep 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants