Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't change default TLS implementation based on features #960

Closed
jdisanti opened this issue Dec 10, 2021 · 2 comments
Closed

Don't change default TLS implementation based on features #960

jdisanti opened this issue Dec 10, 2021 · 2 comments
Labels
breaking-change This will require a breaking change client sdk-ga
Milestone
SDK GA

Comments

@jdisanti
Copy link
Collaborator

If the rustls feature is enabled, then we should default to rustls, but don't change the default to native TLS if only the native-tls feature is enabled. Changing behavior based on feature flags is dangerous since adding new dependencies could unexpectedly change an application's behavior. Instead, switching from the default to native-tls should require an additional, explicit, piece of configuration.
@jdisanti jdisanti added the breaking-change This will require a breaking change label Dec 10, 2021
@rcoh rcoh added this to the GA milestone Dec 13, 2021
@jdisanti
Copy link
Collaborator Author

This would probably be implemented along side #1225

@jdisanti jdisanti mentioned this issue Oct 13, 2022
Closed
@jdisanti
Copy link
Collaborator Author

native-tls was removed, so this is no longer relevant.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
breaking-change This will require a breaking change client sdk-ga
Projects
None yet
Milestone
SDK GA
Development

No branches or pull requests
2 participants
@jdisanti @rcoh