Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Investigate Performance Regression in Release Workflows #3947

Open
landonxjames opened this issue Dec 18, 2024 · 1 comment
Open

Investigate Performance Regression in Release Workflows #3947

landonxjames opened this issue Dec 18, 2024 · 1 comment

Comments

@landonxjames
Copy link
Contributor

After merging #3936 and bumping our MSRV to 1.81.0 we have encountered a performance regression in one of our release steps that executes cargo package. This appears to be linked to rust-lang/cargo#13960 which made cargo package interact with git even when the --allow-dirty flag is passed. Previously that flag disabled any git actions from the cargo package command.

We need to explore potential ways around this until the issue is fixed. In local testing removing the .git directory substantially improves performance, but we need to confirm that the diff between the packaged SDKs isn't impacted by this change.

@landonxjames
Copy link
Contributor Author

Issue cut to Cargo team: rust-lang/cargo#14955

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant