Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support stringArray type in endpoints params #3742

Merged
merged 5 commits into from
Jul 8, 2024

Conversation

landonxjames
Copy link
Contributor

Motivation and Context

Description

Updated our endpoint rule generation to support the new stringArray parameter type

Testing

Updated the existing EndpointsDecoratorTest with tests for stringArray

Checklist

  • I have updated CHANGELOG.next.toml if I made changes to the smithy-rs codegen or runtime crates

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@landonxjames landonxjames requested review from a team as code owners July 7, 2024 05:11
Copy link

github-actions bot commented Jul 7, 2024

A new generated diff is ready to view.

  • No codegen difference in the AWS SDK
  • No codegen difference in the Client Test
  • No codegen difference in the Server Test
  • No codegen difference in the Server Test Python
  • No codegen difference in the Server Test Typescript

A new doc preview is ready to view.

…egen/client/smithy/endpoint/EndpointsDecoratorTest.kt

Co-authored-by: Zelda Hessler <[email protected]>
Copy link

github-actions bot commented Jul 8, 2024

A new generated diff is ready to view.

  • No codegen difference in the AWS SDK
  • No codegen difference in the Client Test
  • No codegen difference in the Server Test
  • No codegen difference in the Server Test Python
  • No codegen difference in the Server Test Typescript

A new doc preview is ready to view.

Copy link

github-actions bot commented Jul 8, 2024

A new generated diff is ready to view.

  • No codegen difference in the AWS SDK
  • No codegen difference in the Client Test
  • No codegen difference in the Server Test
  • No codegen difference in the Server Test Python
  • No codegen difference in the Server Test Typescript

A new doc preview is ready to view.

landonxjames and others added 2 commits July 8, 2024 12:53
…egen/client/smithy/endpoint/generators/EndpointParamsInterceptorGenerator.kt

Co-authored-by: Zelda Hessler <[email protected]>
Copy link

github-actions bot commented Jul 8, 2024

A new generated diff is ready to view.

  • No codegen difference in the AWS SDK
  • No codegen difference in the Client Test
  • No codegen difference in the Server Test
  • No codegen difference in the Server Test Python
  • No codegen difference in the Server Test Typescript

A new doc preview is ready to view.

@landonxjames landonxjames added this pull request to the merge queue Jul 8, 2024
Merged via the queue into main with commit 2295d5b Jul 8, 2024
44 checks passed
@landonxjames landonxjames deleted the landonxjames/ep-lists branch July 8, 2024 20:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants