Adding impl Display for enum #3391
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rcoh
reviewed
Feb 5, 2024
| """ | ||
| impl #{Display} for $UnknownVariantValue { | ||
| fn fmt(&self, f: &mut #{Fmt}::Formatter) -> #{Fmt}::Result { | ||
| write!(f,"{}",self.0) |
There was a problem hiding this comment.
Suggested change
| write!(f,"{}",self.0) | |
| write!(f, "{}", self.0) |
| """, | ||
| ) | ||
| } | ||
| rust(""" ${context.enumName}::Unknown(value) => write!(f,"{}",value) """) |
There was a problem hiding this comment.
Suggested change
| rust(""" ${context.enumName}::Unknown(value) => write!(f,"{}",value) """) | |
| rust("""${context.enumName}::Unknown(value) => write!(f,"{}",value)""") |
CHANGELOG.next.toml
Outdated
| @@ -28,3 +28,9 @@ message = "Add `try_into_http1x` and `try_from_http1x` to Request and Response c | |||
| references = ["aws-sdk-rust#977", "smithy-rs#3365", "smithy-rs#3373"] | |||
| meta = { "breaking" = false, "bug" = false, "tada" = false } | |||
| author = "rcoh" | |||
|
|
|||
| [[smithy-rs]] | |||
| message = "Added impl Display trait to Enum." | |||
There was a problem hiding this comment.
Suggested change
| message = "Added impl Display trait to Enum." | |
| message = "Added impl `Display` to Enums." |
| @@ -28,3 +28,9 @@ message = "Add `try_into_http1x` and `try_from_http1x` to Request and Response c | |||
| references = ["aws-sdk-rust#977", "smithy-rs#3365", "smithy-rs#3373"] | |||
| meta = { "breaking" = false, "bug" = false, "tada" = false } | |||
| author = "rcoh" | |||
|
|
|||
| [[smithy-rs]] | |||
There was a problem hiding this comment.
since this also impacts the SDK, we should add a duplicate entry under aws-sdk-rust
CHANGELOG.next.toml
Outdated
|
|
||
| [[smithy-rs]] | ||
| message = "Added impl Display trait to Enum." | ||
| references = ["smithy-rs#3336"] |
There was a problem hiding this comment.
Suggested change
| references = ["smithy-rs#3336"] | |
| references = ["smithy-rs#3336", "smithy-rs#3391"] |
| @@ -94,6 +94,8 @@ class ClientEnumGeneratorTest { | |||
| """ | |||
| assert_eq!(format!("{:?}", SomeEnum::Foo), "Foo"); | |||
| assert_eq!(format!("{:?}", SomeEnum::Bar), "Bar"); | |||
| assert_eq!(SomeEnum::Foo.to_string(), "Foo"); | |||
There was a problem hiding this comment.
can you have one of these go directly for format!("{}", value) instead of to_string for completeness?
iampkmone
force-pushed
the
feature/display_trait_enum
branch
from
119b2cf to
85d40cc
Compare
iampkmone
commented
Feb 6, 2024
| """ | ||
| impl #{Display} for $UnknownVariantValue { | ||
| fn fmt(&self, f: &mut #{Fmt}::Formatter) -> #{Fmt}::Result { | ||
| write!(f, "{}", self.0) |
There was a problem hiding this comment.
Addressed the formatting.
iampkmone
commented
Feb 6, 2024
| """, | ||
| ) | ||
| } | ||
| rust("""${context.enumName}::Unknown(value) => write!(f,"{}",value)""") |
There was a problem hiding this comment.
Addressed the formatting.
iampkmone
force-pushed
the
feature/display_trait_enum
branch
from
85d40cc to
e95d5d1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and Context
This change address the #3335
Description
Added Display trait to the Enum.
Testing
Updated the ClientEnumGeneratorTest.kt which test the
impl Displayfor the enums.Checklist
CHANGELOG.next.tomlif I made changes to the smithy-rs codegen or runtime cratesBy submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.