Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make it possible to retry any response #3389

Merged
merged 5 commits into from
Apr 2, 2024

Conversation

Velfi
Copy link
Contributor

@Velfi Velfi commented Jan 30, 2024

Motivation and Context

awsdocs/aws-doc-sdk-examples#6021

Description

This change makes it possible to retry requests that were successfully deserialized into an output.

Testing

I wrote a test

Checklist

  • I have updated CHANGELOG.next.toml if I made changes to the smithy-rs codegen or runtime crates
  • I have updated CHANGELOG.next.toml if I made changes to the AWS SDK, generated SDK code, or SDK runtime crates

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Copy link

A new generated diff is ready to view.

  • AWS SDK (ignoring whitespace)
  • No codegen difference in the Client Test
  • No codegen difference in the Server Test
  • No codegen difference in the Server Test Python
  • No codegen difference in the Server Test Typescript

A new doc preview is ready to view.

Copy link
Collaborator

@rcoh rcoh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good

@Velfi Velfi marked this pull request as ready for review April 1, 2024 15:28
@Velfi Velfi requested a review from a team as a code owner April 1, 2024 15:28
Copy link

github-actions bot commented Apr 1, 2024

A new generated diff is ready to view.

  • AWS SDK (ignoring whitespace)
  • No codegen difference in the Client Test
  • No codegen difference in the Server Test
  • No codegen difference in the Server Test Python
  • No codegen difference in the Server Test Typescript

A new doc preview is ready to view.

@@ -44,6 +44,15 @@ impl ShouldAttempt {
_ => panic!("Expected this to be the `YesAfterDelay` variant but it was the `{self:?}` variant instead"),
}
}

/// If this isn't a `No` variant, panic.
pub fn expect_no(self) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this method used outside tests?

Copy link
Contributor Author

@Velfi Velfi Apr 2, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No. It's defined in an impl block with #[cfg(feature = "test-util")]. Of course, that's just beyond the fold so it's not clear that that's the case. Thanks GitHub.

@Velfi Velfi requested a review from a team as a code owner April 2, 2024 14:18
@Velfi Velfi enabled auto-merge April 2, 2024 14:19
Copy link

github-actions bot commented Apr 2, 2024

A new generated diff is ready to view.

  • AWS SDK (ignoring whitespace)
  • No codegen difference in the Client Test
  • No codegen difference in the Server Test
  • No codegen difference in the Server Test Python
  • No codegen difference in the Server Test Typescript

A new doc preview is ready to view.

@Velfi Velfi added this pull request to the merge queue Apr 2, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Apr 2, 2024
@Velfi Velfi added this pull request to the merge queue Apr 2, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Apr 2, 2024
@Velfi Velfi added this pull request to the merge queue Apr 2, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to a conflict with the base branch Apr 2, 2024
@Velfi Velfi enabled auto-merge April 2, 2024 18:36
Copy link

github-actions bot commented Apr 2, 2024

A new generated diff is ready to view.

  • AWS SDK (ignoring whitespace)
  • No codegen difference in the Client Test
  • No codegen difference in the Server Test
  • No codegen difference in the Server Test Python
  • No codegen difference in the Server Test Typescript

A new doc preview is ready to view.

@Velfi Velfi added this pull request to the merge queue Apr 2, 2024
Merged via the queue into main with commit f19a9da Apr 2, 2024
42 checks passed
@Velfi Velfi deleted the zhessler-make-it-possible-to-retry-any-response branch April 2, 2024 19:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants