Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove incorrect defaults for iot #3256

Merged

Conversation

milesziemer
Copy link
Contributor

@milesziemer milesziemer commented Nov 25, 2023

Motivation and Context

The IoT Smithy model we have is incorrect, resulting in some types being generated as non-optional when they should be optional.

Description

Removes the defaults of a few shapes for iot, which are meant to be nullable. Can remove this when the model is fixed upstream.

Also changed some of the other shapes in RemoveDefaultsDecorator to use the synthetic shape id, but this didn't impact generated code - just for consistency.

Testing

  • Generated IoT SDK and verified diff is expected

Checklist

  • I have updated CHANGELOG.next.toml if I made changes to the AWS SDK, generated SDK code, or SDK runtime crates

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@milesziemer milesziemer requested a review from a team as a code owner November 25, 2023 22:41
@milesziemer milesziemer force-pushed the remove-defaults-from-iot branch from f463ba6 to c6d689d Compare November 25, 2023 22:44
@milesziemer milesziemer requested a review from a team as a code owner November 25, 2023 22:44
@milesziemer milesziemer changed the base branch from main to smithy-rs-release-1.x.y November 25, 2023 23:34
Removes the defaults of a few shapes for iot, which are meant to
be nullable. Can remove this when the model is fixed upstream.
@milesziemer milesziemer force-pushed the remove-defaults-from-iot branch from c6d689d to dfedb2e Compare November 25, 2023 23:44
Copy link
Collaborator

@rcoh rcoh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. We will yank 1.1 and 1.2 of the iot service

@rcoh rcoh merged commit c62c9fb into smithy-lang:smithy-rs-release-1.x.y Nov 27, 2023
39 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants