Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move RequestId to aws-types #3160

Merged
merged 4 commits into from
Nov 11, 2023
Merged

Move RequestId to aws-types #3160

merged 4 commits into from
Nov 11, 2023

Conversation

jdisanti
Copy link
Collaborator

@jdisanti jdisanti commented Nov 9, 2023

This PR moves RequestId into the aws-types stable crate.


By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@jdisanti jdisanti added the breaking-change This will require a breaking change label Nov 9, 2023
@jdisanti jdisanti requested review from a team as code owners November 9, 2023 01:53
Copy link

github-actions bot commented Nov 9, 2023

A new generated diff is ready to view.

  • AWS SDK (ignoring whitespace)
  • No codegen difference in the Client Test
  • No codegen difference in the Server Test
  • No codegen difference in the Server Test Python
  • No codegen difference in the Server Test Typescript

A new doc preview is ready to view.

@jdisanti jdisanti force-pushed the jdisanti-move-request-id branch from bbff3b7 to 04949e5 Compare November 10, 2023 23:52
@jdisanti jdisanti requested review from a team as code owners November 10, 2023 23:52
Copy link

A new generated diff is ready to view.

  • AWS SDK (ignoring whitespace)
  • No codegen difference in the Client Test
  • No codegen difference in the Server Test
  • No codegen difference in the Server Test Python
  • No codegen difference in the Server Test Typescript

A new doc preview is ready to view.

@jdisanti jdisanti force-pushed the jdisanti-move-request-id branch from 1810a25 to 04949e5 Compare November 11, 2023 00:27
Copy link

A new generated diff is ready to view.

A new doc preview is ready to view.

Base automatically changed from jdisanti-http-response to main November 11, 2023 00:56
@jdisanti jdisanti force-pushed the jdisanti-move-request-id branch from 04949e5 to 13846d1 Compare November 11, 2023 00:57
Copy link

A new generated diff is ready to view.

  • AWS SDK (ignoring whitespace)
  • No codegen difference in the Client Test
  • No codegen difference in the Server Test
  • No codegen difference in the Server Test Python
  • No codegen difference in the Server Test Typescript

A new doc preview is ready to view.

Copy link

A new generated diff is ready to view.

  • AWS SDK (ignoring whitespace)
  • No codegen difference in the Client Test
  • No codegen difference in the Server Test
  • No codegen difference in the Server Test Python
  • No codegen difference in the Server Test Typescript

A new doc preview is ready to view.

@jdisanti jdisanti merged commit d4e2745 into main Nov 11, 2023
40 of 41 checks passed
@jdisanti jdisanti deleted the jdisanti-move-request-id branch November 11, 2023 02:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking-change This will require a breaking change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants