Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move rust-runtime/aws-smithy-http-server-python/examples to /examples #2489

Closed
hlbarber opened this issue Mar 23, 2023 · 1 comment
Closed

Move rust-runtime/aws-smithy-http-server-python/examples to /examples #2489

hlbarber opened this issue Mar 23, 2023 · 1 comment
Labels
blocked good first issue Good for newcomers python-server Python server SDK refactoring Changes that do not affect our users, mostly focused on maintainability server Rust server SDK

Comments

@hlbarber
Copy link
Contributor

We have moved rust-runtime/aws-smithy-http-server/examples to /examples in this PR.

We should do the same for rust-runtime/aws-smithy-http-server-python/examples and attempt to merge the make files and README.md perhaps.

If this doesn't make sense then maybe we should have examples-python?
@hlbarber hlbarber added good first issue Good for newcomers server Rust server SDK python-server Python server SDK refactoring Changes that do not affect our users, mostly focused on maintainability labels Mar 23, 2023
@crisidev
Copy link
Contributor

Marked as blocked as this should be done after we have refactored the Python implementation, especially around typing stubs generation.

@crisidev crisidev mentioned this issue Apr 13, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
blocked good first issue Good for newcomers python-server Python server SDK refactoring Changes that do not affect our users, mostly focused on maintainability server Rust server SDK
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@crisidev @hlbarber