Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Supress warnings for deprecated shapes #2047

Closed
jjant opened this issue Dec 1, 2022 · 4 comments
Closed

Supress warnings for deprecated shapes #2047

jjant opened this issue Dec 1, 2022 · 4 comments

Comments

@jjant
Copy link
Contributor

jjant commented Dec 1, 2022

We still support a bunch of deprecated shapes (EnumShape EnumTrait, SetShape), and these generate a lot of warnings while building.

@jdisanti
Copy link
Collaborator

jdisanti commented Dec 1, 2022

Did you mean EnumTrait? EnumShape is the new shininess.

I think we actually have a path forward to stop referencing both of these in our code. SetShape extends ListShape, so we can just stop matching on it entirely.

@82marbag
Copy link
Contributor

82marbag commented Dec 2, 2022

For enums: #1932 (waiting for a conversation with the smithy team to be resolved)

I'll cut one for sets

@jjant
Copy link
Contributor Author

jjant commented Dec 2, 2022

Yes, I meant EnumTrait! Good catch.

We can't remove all references of SetShape afaik, because things like

override fun setShape(shape: SetShape) {}

don't compile if you replace that with ListShape.


Edit: Looks like the default impl for setShape just invokes listShape so we can probably just remove our overrides in our visitors 🤔.

@jdisanti
Copy link
Collaborator

jdisanti commented Apr 5, 2024

Duplicate of #1670

@jdisanti jdisanti marked this as a duplicate of #1670 Apr 5, 2024
@jdisanti jdisanti closed this as completed Apr 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants