Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Detect uses of unsupported regexes early #2026

Closed
Tracked by #1401
jjant opened this issue Nov 23, 2022 · 1 comment
Closed
Tracked by #1401

Detect uses of unsupported regexes early #2026

jjant opened this issue Nov 23, 2022 · 1 comment
Assignees
Milestone

Comments

@jjant
Copy link
Contributor

jjant commented Nov 23, 2022

As mentioned in this thread: #1998 (comment), Smithy accepts more regexes than the regex crate supports (the crate doesn't support look-behinds, etc) in the @pattern trait.

These unsupported regexes should be detected early, options include:

  • During ${service}Builder::build() so that customers see an error as soon as they attempt to setup their server
  • Generating tests that Regex::compile the regex, so builds fail if the regex is unsupported
@jjant
Copy link
Contributor Author

jjant commented Jan 11, 2023

Completed in #2058.

@jjant jjant closed this as completed Jan 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants