Add PluginExt extension trait and FilterByOperationName plugin #1837
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hlbarber
commented
Oct 11, 2022
| @@ -193,8 +193,11 @@ pub use upgrade::*; | |||
| /// | |||
| /// The `L` is held and applied lazily during [`Upgradable::upgrade`]. | |||
| pub struct Operation<S, L = Identity> { | |||
| inner: S, | |||
| layer: L, | |||
| /// The inner [`Service`](tower::Service) representing the logic of the operation. | |||
There was a problem hiding this comment.
These have become public in order to allow Plugin developers access to them.
Is this too severe? Maybe we should document that the average customer should use the from_handler/from_service methods?
There was a problem hiding this comment.
If we want customers to be able to write their own plugins, along the same lines of what we are doing here with the filtering, I don't see many other options.
|
A new generated diff is ready to view.
A new doc preview is ready to view. |
|
A new generated diff is ready to view.
A new doc preview is ready to view. |
jjant
reviewed
Oct 11, 2022
2 tasks
|
A new generated diff is ready to view.
A new doc preview is ready to view. |
jjant
approved these changes
Oct 11, 2022
LukeMathWalker
approved these changes
Oct 11, 2022
hlbarber
force-pushed
the
harryb/plugin-ext
branch
from
d3b77c3
to
6340483
Compare
|
A new generated diff is ready to view.
A new doc preview is ready to view. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and Context
Customers may not want to apply a
Pluginto every operation in their service. They might want to filter application by operation name.Description
Plugins to live in their own folders.PluginExtextension trait, which has methodsstackandfilter_by_operation_name.FilterByOperationNamePlugin.