Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Display and Debug don't honor @sensitive for individual fields #1833

Open
jjant opened this issue Oct 10, 2022 · 2 comments
Open

Display and Debug don't honor @sensitive for individual fields #1833

jjant opened this issue Oct 10, 2022 · 2 comments
Labels
blocked high-priority High priority issue

Comments

@jjant
Copy link
Contributor

jjant commented Oct 10, 2022

As discussed in #1743 (comment), the current @sensitive implementation only respects the trait when logging the structure containing the sensitive field, but not when logging the field itself.


A possible fix to this issue, is to newtype @sensitive shapes in the generated code, overriding their Display and Debug implementations through the Sensitive type.

@82marbag
Copy link
Contributor

82marbag commented Jan 3, 2023

We’ve discussed that we are currently not going ahead with this task until further design and agreement on how to proceed.

@82marbag
Copy link
Contributor

The proposal has been made. Waiting for the final review and decision before unblocking this issue

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
blocked high-priority High priority issue
Projects
None yet
Development

No branches or pull requests

3 participants