Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade smithy-rs to Rust 1.62 #1814

Closed
jjant opened this issue Oct 5, 2022 · 4 comments
Closed

Upgrade smithy-rs to Rust 1.62 #1814

jjant opened this issue Oct 5, 2022 · 4 comments

Comments

@jjant
Copy link
Contributor

jjant commented Oct 5, 2022

Description

As per our MSRV policy, we should support Rust 1.62 (current stable is 1.64).
We're currently getting CI failures because the SDK uses 1.62 APIs, example here.
@jdisanti
Copy link
Collaborator

jdisanti commented Oct 5, 2022

That example CI failure is being fixed: awsdocs/aws-doc-sdk-examples#3739

In the future, the examples repo will check against our MSRV so this shouldn't happen again going forward.

@jjant
Copy link
Contributor Author

jjant commented Oct 6, 2022

Just to clarify, our current MSRV is 1.62, so the example should've been supported by us.

@jdisanti
Copy link
Collaborator

jdisanti commented Oct 6, 2022

The policy allows us the flexibility for it to be 1.62, but it's not actually 1.62 until we upgrade to it.

@jjant
Copy link
Contributor Author

jjant commented Oct 31, 2022

Completed in #1825.

@jjant jjant closed this as completed Oct 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jdisanti @jjant