You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
After #1635, we made it so that if the runtimeConfig key is specified, you now don't need to specify version: "DEFAULT" to make the code generated crate depend on the runtime crates on crates.io. Instead, now users have more flexibility: by default it will use the latest crates on crates.io, but they can also use the versions (note the plural) key to specify an explicit version for a runtime crate, or a path dependency.
However, if the runtimeConfig key is not specified, then we go through the else branch here
and RuntimeCrateLocation is thus set to RuntimeCrateLocation.Path("../"), a path dependency. So the default behavior is still not using the latest runtime crate versions on crates.io in this case.
The text was updated successfully, but these errors were encountered:
After #1635, we made it so that if the
runtimeConfig
key is specified, you now don't need to specifyversion: "DEFAULT"
to make the code generated crate depend on the runtime crates on crates.io. Instead, now users have more flexibility: by default it will use the latest crates on crates.io, but they can also use theversions
(note the plural) key to specify an explicit version for a runtime crate, or a path dependency.However, if the
runtimeConfig
key is not specified, then we go through the else branch herehttps://github.com/awslabs/smithy-rs/blob/30d985ad9d39849bb40705d244413eae2764ba7f/codegen/src/main/kotlin/software/amazon/smithy/rust/codegen/smithy/RuntimeTypes.kt#L92-L78
and
RuntimeCrateLocation
is thus set toRuntimeCrateLocation.Path("../")
, a path dependency. So the default behavior is still not using the latest runtime crate versions on crates.io in this case.The text was updated successfully, but these errors were encountered: