Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

When runtimeConfig is _not_ specified, the default behavior is still not using the latest runtime crate versions on crates.io #1676

Closed
david-perez opened this issue Aug 26, 2022 · 2 comments
Assignees

Comments

@david-perez
Copy link
Contributor

After #1635, we made it so that if the runtimeConfig key is specified, you now don't need to specify version: "DEFAULT" to make the code generated crate depend on the runtime crates on crates.io. Instead, now users have more flexibility: by default it will use the latest crates on crates.io, but they can also use the versions (note the plural) key to specify an explicit version for a runtime crate, or a path dependency.

However, if the runtimeConfig key is not specified, then we go through the else branch here

https://github.com/awslabs/smithy-rs/blob/30d985ad9d39849bb40705d244413eae2764ba7f/codegen/src/main/kotlin/software/amazon/smithy/rust/codegen/smithy/RuntimeTypes.kt#L92-L78

and RuntimeCrateLocation is thus set to RuntimeCrateLocation.Path("../"), a path dependency. So the default behavior is still not using the latest runtime crate versions on crates.io in this case.

@82marbag
Copy link
Contributor

Can this be closed?

@david-perez
Copy link
Contributor Author

Yes. Closing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants