add: article on difficulties Zelda encountered while implementing streaming checksums #1427
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
add: article on difficulties Zelda encountered while implementing streaming checksums update: SUMMARY.md table of contents
rcoh
approved these changes
May 31, 2022
| constructed from files. In these cases we can ask the operating system for the file size before sending the request. So | ||
| long as that size doesn't change during sending of the request, all is well. In any other case, the request will fail. | ||
|
|
||
| ### Adding trailers to a request changes the size of that request |
Comment on lines
+265
to
+275
| ```rust | ||
| use axum::{ | ||
| body::{Body, Bytes}, | ||
| http::{request::Parts, Request, StatusCode}, | ||
| middleware::{self, Next}, | ||
| response::IntoResponse, | ||
| routing::put, | ||
| Router, | ||
| }; | ||
| use std::net::SocketAddr; | ||
| use tracing_subscriber::{layer::SubscriberExt, util::SubscriberInitExt}; |
There was a problem hiding this comment.
do you think we should bundle this in the tools directory?
There was a problem hiding this comment.
I'll submit a separate PR for that.
rcoh
reviewed
May 31, 2022
|
A new generated diff is ready to view.
A new doc preview is ready to view. Rust Wrk benchmark report:Duration: 90 sec, Connections: 32, Threads: 2
|
…e_that_relies_on_HTTP.md
|
A new generated diff is ready to view.
A new doc preview is ready to view. Rust Wrk benchmark report:Duration: 90 sec, Connections: 32, Threads: 2
|
|
A new generated diff is ready to view.
A new doc preview is ready to view. Rust Wrk benchmark report:Duration: 90 sec, Connections: 32, Threads: 2
|
Velfi
deleted the
add/writing_and_debugging_a_low-level_feature_that_relies_on_HTTP.md
branch
82marbag
pushed a commit
that referenced
this pull request
Jun 7, 2022
…eaming checksums (#1427) * add: contributing docs overview page add: article on difficulties Zelda encountered while implementing streaming checksums update: SUMMARY.md table of contents add: link to contributor design docs in CONTRIBUTING.md
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.