Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

runtimeConfig: { version: "DEFAULT" } is _not_ the default #1416

Closed
david-perez opened this issue May 26, 2022 · 0 comments
Closed

runtimeConfig: { version: "DEFAULT" } is _not_ the default #1416

david-perez opened this issue May 26, 2022 · 0 comments
Assignees
Labels
good first issue Good for newcomers

Comments

@david-perez
Copy link
Contributor

By default, generated crates point to runtime crates using a relative path into the smithy-rs repository. However, you can add

runtimeConfig: { version: "DEFAULT" }

in your smithy-build.json and then it will point to the crates in crates.io.

It's super confusing because you have to opt into the "DEFAULT" behavior.

We should make "DEFAULT" the default behavior i.e. not have to add "DEFAULT".

It'd also be nice if we could override specific crate versions e.g. runtimeConfig: { versions: [ { aws-smithy-http-server: "0.30.0-alpha" } ] }. This might prove flexible when we need to tell users to rollback to a previous compatible / non-vulnerable version, instead of them having to wait for us to publish a new version of the runtime crate / us making a code change.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

2 participants