Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gradle 7? #1167

Closed
guymguym opened this issue Feb 8, 2022 · 5 comments · Fixed by #1411
Closed

gradle 7? #1167

guymguym opened this issue Feb 8, 2022 · 5 comments · Fixed by #1411

Comments

@guymguym
Copy link
Contributor

guymguym commented Feb 8, 2022

I see that smithy project updated to gradle 7
smithy-lang/smithy#1085

When is it going to be updated for smithy-rs?

The reason I "care" is that with gradle 6 I have to manually install jdk 11 (or up to 14) which is quite old.

@Velfi
Copy link
Contributor

Velfi commented Feb 14, 2022

We agree that this situation isn't ideal but due to internal constraints, we don't plan to address this at this time. As soon as those internal constraints get relaxed or we have a good mitigation we can revisit this issue, but I'm sorry to say that we don't currently have any estimate on when that will be.

@guymguym
Copy link
Contributor Author

Thanks @Velfi That's OK, it's not blocking me in any way just wanted to keep track.
Just while we're at at - if you'd be willing to highlight a few of the things that would need to be updated in the repo, I might be able to take a first stab. Only if it makes sense. Thanks!!

@Velfi
Copy link
Contributor

Velfi commented Feb 14, 2022

Ah, sorry. When I said "internal" I was referring to something internal to AWS, not the SDK. If you apply for a job and get hired I'd be happy to be more specific 😜

@guymguym
Copy link
Contributor Author

Got it, no worries, gradle 6 FTW 😉

@david-perez
Copy link
Contributor

We are no longer blocked. We should be able to upgrade to Gradle 7.

@rcoh rcoh mentioned this issue May 25, 2022
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants