From ff13b087fed3f8cb6635fddce6a7016d68fb6ada Mon Sep 17 00:00:00 2001 From: Nicolas Farrier Date: Wed, 21 Sep 2022 04:26:02 -0700 Subject: [PATCH] =?UTF-8?q?Run=20`cargo=20clippy`=20when=20building=20the?= =?UTF-8?q?=20Pok=C3=A9mon=20Service=20(#1742)?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit --- CHANGELOG.next.toml | 8 +++++++- .../aws-smithy-http-server-python/examples/Makefile | 3 +++ rust-runtime/aws-smithy-http-server/examples/Makefile | 6 ++++++ tools/ci-build/scripts/check-server-e2e-test | 3 +-- tools/ci-build/scripts/check-server-python-e2e-test | 2 +- 5 files changed, 18 insertions(+), 4 deletions(-) diff --git a/CHANGELOG.next.toml b/CHANGELOG.next.toml index fc4c4c2578..3b1b94fedc 100644 --- a/CHANGELOG.next.toml +++ b/CHANGELOG.next.toml @@ -9,4 +9,10 @@ # message = "Fix typos in module documentation for generated crates" # references = ["smithy-rs#920"] # meta = { "breaking" = false, "tada" = false, "bug" = false, "target" = "client | server | all"} -# author = "rcoh" \ No newline at end of file +# author = "rcoh" + +[[rust-runtime]] +message = "Pokémon Service example code now runs clippy during build." +references = ["smithy-rs#1727"] +meta = { "breaking" = false, "tada" = false, "bug" = false } +author = "GeneralSwiss" diff --git a/rust-runtime/aws-smithy-http-server-python/examples/Makefile b/rust-runtime/aws-smithy-http-server-python/examples/Makefile index a44194721c..c3af9f378b 100644 --- a/rust-runtime/aws-smithy-http-server-python/examples/Makefile +++ b/rust-runtime/aws-smithy-http-server-python/examples/Makefile @@ -24,6 +24,9 @@ codegen: cp -av $(SERVER_SDK_SRC)/* $(SERVER_SDK_DST)/ cp -av $(CLIENT_SDK_SRC)/* $(CLIENT_SDK_DST)/ +clippy: codegen + cargo clippy + build: codegen cargo build ln -sf $(DEBUG_SHARED_LIBRARY_SRC) $(SHARED_LIBRARY_DST) diff --git a/rust-runtime/aws-smithy-http-server/examples/Makefile b/rust-runtime/aws-smithy-http-server/examples/Makefile index 28f49f2d5d..a31e805d8b 100644 --- a/rust-runtime/aws-smithy-http-server/examples/Makefile +++ b/rust-runtime/aws-smithy-http-server/examples/Makefile @@ -20,6 +20,12 @@ build: codegen run: codegen cargo run +clippy: codegen + cargo clippy + +test: codegen + cargo test + doc-open: codegen cargo doc --no-deps --open diff --git a/tools/ci-build/scripts/check-server-e2e-test b/tools/ci-build/scripts/check-server-e2e-test index 9a37b3aabc..8b17890724 100755 --- a/tools/ci-build/scripts/check-server-e2e-test +++ b/tools/ci-build/scripts/check-server-e2e-test @@ -6,5 +6,4 @@ set -eux cd smithy-rs/rust-runtime/aws-smithy-http-server/examples -make -cargo test +make test clippy diff --git a/tools/ci-build/scripts/check-server-python-e2e-test b/tools/ci-build/scripts/check-server-python-e2e-test index 9b55c6377e..fbaf9b0d67 100755 --- a/tools/ci-build/scripts/check-server-python-e2e-test +++ b/tools/ci-build/scripts/check-server-python-e2e-test @@ -6,4 +6,4 @@ set -eux cd smithy-rs/rust-runtime/aws-smithy-http-server-python/examples -make test +make test clippy