From 24af6dab464a3457ed0bbe24763f80ef1fa511e4 Mon Sep 17 00:00:00 2001 From: Nick Date: Fri, 16 Sep 2022 23:06:05 -0700 Subject: [PATCH] =?UTF-8?q?Run=20`cargo=20clippy`=20when=20building=20the?= =?UTF-8?q?=20Pok=C3=A9mon=20Service?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit --- CHANGELOG.next.toml | 6 ++++++ .../aws-smithy-http-server-python/examples/Makefile | 3 +++ rust-runtime/aws-smithy-http-server/examples/Makefile | 6 ++++++ tools/ci-build/scripts/check-server-e2e-test | 3 +-- tools/ci-build/scripts/check-server-python-e2e-test | 2 +- 5 files changed, 17 insertions(+), 3 deletions(-) diff --git a/CHANGELOG.next.toml b/CHANGELOG.next.toml index a2a98e76179..a661a23e7d7 100644 --- a/CHANGELOG.next.toml +++ b/CHANGELOG.next.toml @@ -11,6 +11,12 @@ # meta = { "breaking" = false, "tada" = false, "bug" = false, "target" = "client | server | all"} # author = "rcoh" +[[rust-runtime]] +message = "Pokémon Service example code now runs clippy during build." +references = ["smithy-rs#1727"] +meta = { "breaking" = false, "tada" = false, "bug" = false } +author = "GeneralSwiss" + [[aws-sdk-rust]] message = "`aws_config::RetryConfig` no longer implements `Default`, and its `new` function has been replaced with `standard`." references = ["smithy-rs#1603", "aws-sdk-rust#586"] diff --git a/rust-runtime/aws-smithy-http-server-python/examples/Makefile b/rust-runtime/aws-smithy-http-server-python/examples/Makefile index a44194721c0..c3af9f378b1 100644 --- a/rust-runtime/aws-smithy-http-server-python/examples/Makefile +++ b/rust-runtime/aws-smithy-http-server-python/examples/Makefile @@ -24,6 +24,9 @@ codegen: cp -av $(SERVER_SDK_SRC)/* $(SERVER_SDK_DST)/ cp -av $(CLIENT_SDK_SRC)/* $(CLIENT_SDK_DST)/ +clippy: codegen + cargo clippy + build: codegen cargo build ln -sf $(DEBUG_SHARED_LIBRARY_SRC) $(SHARED_LIBRARY_DST) diff --git a/rust-runtime/aws-smithy-http-server/examples/Makefile b/rust-runtime/aws-smithy-http-server/examples/Makefile index 28f49f2d5d8..a31e805d8bf 100644 --- a/rust-runtime/aws-smithy-http-server/examples/Makefile +++ b/rust-runtime/aws-smithy-http-server/examples/Makefile @@ -20,6 +20,12 @@ build: codegen run: codegen cargo run +clippy: codegen + cargo clippy + +test: codegen + cargo test + doc-open: codegen cargo doc --no-deps --open diff --git a/tools/ci-build/scripts/check-server-e2e-test b/tools/ci-build/scripts/check-server-e2e-test index 9a37b3aabc2..8b178907246 100755 --- a/tools/ci-build/scripts/check-server-e2e-test +++ b/tools/ci-build/scripts/check-server-e2e-test @@ -6,5 +6,4 @@ set -eux cd smithy-rs/rust-runtime/aws-smithy-http-server/examples -make -cargo test +make test clippy diff --git a/tools/ci-build/scripts/check-server-python-e2e-test b/tools/ci-build/scripts/check-server-python-e2e-test index 9b55c6377e1..fbaf9b0d671 100755 --- a/tools/ci-build/scripts/check-server-python-e2e-test +++ b/tools/ci-build/scripts/check-server-python-e2e-test @@ -6,4 +6,4 @@ set -eux cd smithy-rs/rust-runtime/aws-smithy-http-server-python/examples -make test +make test clippy