Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor synthetic traits to use builtin input and output traits #546

Closed
aajtodd opened this issue Dec 6, 2021 · 1 comment
Closed

Refactor synthetic traits to use builtin input and output traits #546

aajtodd opened this issue Dec 6, 2021 · 1 comment
Labels
codegen Codegen related change

Comments

@aajtodd
Copy link
Contributor

aajtodd commented Dec 6, 2021

Next version of smithy (1.15+) will have support for builtin input and output traits. We currently generate these as synthetic traits and should make use of the new functionality to be forwards compatible with Smithy 2.0 (rules around input and output structures will be different than other structures in 2.0 regarding @required or default value)

This also introduced a new Unit type which signifies an operation really truly doesn't have an input or output. It will be considered a breaking change to go from Unit to having an input or output which will allow us to generate operations targeting Unit without a synthetic input or output type.

@aajtodd aajtodd added the codegen Codegen related change label Dec 6, 2021
@ianbotsf
Copy link
Contributor

We already have a customization in place to deal with synthetic shape generation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
codegen Codegen related change
Projects
None yet
Development

No branches or pull requests

2 participants