Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Investigate adding DslMarker annotations to public APIs for better suggestions #428

Closed
kggilmer opened this issue Jun 29, 2021 · 1 comment · Fixed by #1065
Closed

Investigate adding DslMarker annotations to public APIs for better suggestions #428

kggilmer opened this issue Jun 29, 2021 · 1 comment · Fixed by #1065
Labels
enhancement New feature or request no-auto-closure We do not want this issue to be automatically closed.

Comments

@kggilmer
Copy link
Contributor

The DslMarker annotation was mentioned by JetBrains as a way we can influence type suggestions in Intellij. It was mentioned that this annotation is not stable so we cannot count on it. We could provide feedback back to JB to prioritize stabilization but first we should know:

  1. how much does stability matter w/ something like this?
  2. does application of the annotation meaningfully improve the customer IDE experience
@kggilmer kggilmer added the enhancement New feature or request label Jun 29, 2021
@ianbotsf
Copy link
Contributor

@DslMarker appears to be stable at this time.

@ianbotsf ianbotsf added the no-auto-closure We do not want this issue to be automatically closed. label Apr 8, 2024
@ianbotsf ianbotsf mentioned this issue Apr 11, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request no-auto-closure We do not want this issue to be automatically closed.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: add DSL markers to codegenned structure builders smithy-lang/smithy-kotlin
2 participants
@kggilmer @ianbotsf