Skip to content

Commit 4c80763

Browse files
committed
[pinpoint-apm#9666] Fixed redis properties
1 parent f1a45f7 commit 4c80763

File tree

2 files changed

+12
-23
lines changed

2 files changed

+12
-23
lines changed

realtime/realtime-web/src/main/java/com/navercorp/pinpoint/web/realtime/activethread/count/websocket/ActiveThreadCountHandlerImpl.java

+2-6
Original file line numberDiff line numberDiff line change
@@ -117,8 +117,8 @@ private Consumer<Long> makeTickHandler(SessionContext ctx, WebSocketSession sess
117117
final List<ClusterKey> agentKeys =
118118
this.agentLookupService.getRecentAgents(applicationName, TimeUnit.HOURS.toMillis(1));
119119
final TickHandler handler = new TickHandler(session, applicationName, agentKeys, getFetchers(agentKeys));
120-
121-
return ignoreArgument(decorateHandler(ctx.getTaskDecorator(), handler));
120+
final Runnable decoratedHandler = decorateHandler(ctx.getTaskDecorator(), handler);
121+
return t -> decoratedHandler.run();
122122
}
123123

124124
private List<Fetcher<ATCSupply>> getFetchers(List<ClusterKey> agentKeys) {
@@ -157,10 +157,6 @@ private static Runnable decorateHandler(TimerTaskDecorator decorator, TimerTask
157157
return decorator.decorate(target);
158158
}
159159

160-
private static <T> Consumer<T> ignoreArgument(Runnable r) {
161-
return t -> r.run();
162-
}
163-
164160
private class TickHandler extends TimerTask {
165161

166162
private final WebSocketSession session;

redis/src/main/java/com/navercorp/pinpoint/redis/RedisBasicConfig.java

+10-17
Original file line numberDiff line numberDiff line change
@@ -20,8 +20,6 @@
2020
import io.lettuce.core.TimeoutOptions;
2121
import io.lettuce.core.resource.ClientResources;
2222
import org.springframework.beans.factory.annotation.Value;
23-
import org.springframework.boot.autoconfigure.condition.ConditionalOnMissingBean;
24-
import org.springframework.boot.autoconfigure.condition.ConditionalOnProperty;
2523
import org.springframework.context.annotation.Bean;
2624
import org.springframework.context.annotation.Configuration;
2725
import org.springframework.context.annotation.Import;
@@ -60,7 +58,7 @@ public class RedisBasicConfig {
6058
@Value("${spring.data.redis.port:6379}")
6159
int port;
6260

63-
@Value("${spring.data.redis.cluster.nodes:@null}")
61+
@Value("${spring.data.redis.cluster.nodes}")
6462
List<String> clusterNodes;
6563
@Value("${spring.data.redis.lettuce.client.io-thread-pool-size:8}")
6664
int lettuceIOThreadPoolSize;
@@ -86,22 +84,17 @@ ReactiveRedisTemplate<String, String> reactiveRedisTemplate(ReactiveRedisConnect
8684
}
8785

8886
@Bean
89-
@ConditionalOnProperty("spring.redis.cluster.nodes")
90-
RedisConfiguration redisClusterConfiguration() {
91-
Assert.notNull(clusterNodes, "clusterNodes are required for redis-cluster mode");
87+
RedisConfiguration redisConfiguration() {
88+
if (clusterNodes == null || clusterNodes.isEmpty()) {
89+
Assert.hasText(host, "host is required for redis-standalone mode");
9290

93-
final RedisClusterConfiguration config = new RedisClusterConfiguration(clusterNodes);
94-
config.setUsername(username);
95-
config.setPassword(password);
96-
return config;
97-
}
98-
99-
@Bean
100-
@ConditionalOnMissingBean(RedisConfiguration.class)
101-
RedisConfiguration redisStandaloneConfiguration() {
102-
Assert.hasText(host, "host is required for redis-standalone mode");
91+
final RedisStandaloneConfiguration config = new RedisStandaloneConfiguration(host, port);
92+
config.setUsername(username);
93+
config.setPassword(password);
94+
return config;
95+
}
10396

104-
final RedisStandaloneConfiguration config = new RedisStandaloneConfiguration(host, port);
97+
final RedisClusterConfiguration config = new RedisClusterConfiguration(clusterNodes);
10598
config.setUsername(username);
10699
config.setPassword(password);
107100
return config;

0 commit comments

Comments
 (0)