Build Fails In FreeBSD And Is Breaking Other Projects

[mephistolist]

After pulling my hair out a while, I found my own project was failing to build because it uses pyminizip as a dependency. This github was given for contact:

$ # grep WWW Makefile
WWW= https://github.com/smihica/pyminizip

If you go in its port directory and attempt to build it, you'll see it fail with the following:

pwd

/usr/ports/archivers/py-pyminizip

make install clean

===> Staging for py39-pyminizip-0.2.6
===> py39-pyminizip-0.2.6 depends on package: py39-setuptools>=63.1.0 - found
===> py39-pyminizip-0.2.6 depends on file: /usr/local/bin/python3.9 - found
===> Generating temporary packing list
running install
/usr/local/lib/python3.9/site-packages/setuptools/command/install.py:34: SetuptoolsDeprecationWarning: setup.py install is deprecated. Use build and pip and other standards-based tools.
warnings.warn(
running build
running build_ext
running install_lib
writing byte-compilation script '/tmp/tmp8ftpu3kk.py'
/usr/local/bin/python3.9 /tmp/tmp8ftpu3kk.py
removing /tmp/tmp8ftpu3kk.py
running install_egg_info
running egg_info
writing pyminizip.egg-info/PKG-INFO
writing dependency_links to pyminizip.egg-info/dependency_links.txt
writing top-level names to pyminizip.egg-info/top_level.txt
listing git files failed - pretending there aren't any
reading manifest file 'pyminizip.egg-info/SOURCES.txt'
reading manifest template 'MANIFEST.in'
warning: no previously-included files matching 'ChangeLog' found under directory 'zlib-1.2.11'
warning: no previously-included files matching 'configure' found under directory 'zlib-1.2.11'
warning: no previously-included files matching 'FAQ' found under directory 'zlib-1.2.11'
warning: no previously-included files matching 'INDEX' found under directory 'zlib-1.2.11'
warning: no previously-included files matching 'Makefile*' found under directory 'zlib-1.2.11'
warning: no previously-included files matching 'make_vms.com' found under directory 'zlib-1.2.11'
warning: no previously-included files matching 'README' found under directory 'zlib-1.2.11'
no previously-included directories found matching 'zlib-1.2.11/amiga'
no previously-included directories found matching 'zlib-1.2.11/as400'
no previously-included directories found matching 'zlib-1.2.11/examples'
no previously-included directories found matching 'zlib-1.2.11/msdos'
no previously-included directories found matching 'zlib-1.2.11/old'
no previously-included directories found matching 'zlib-1.2.11/projects'
no previously-included directories found matching 'zlib-1.2.11/qnx'
no previously-included directories found matching 'zlib-1.2.11/win32'
adding license file 'COPYING.txt'
writing manifest file 'pyminizip.egg-info/SOURCES.txt'
removing '/usr/ports/archivers/py-pyminizip/work-py39/stage/usr/local/lib/python3.9/site-packages/pyminizip-0.2.6-py3.9.egg-info' (and everything under it)
Copying pyminizip.egg-info to /usr/ports/archivers/py-pyminizip/work-py39/stage/usr/local/lib/python3.9/site-packages/pyminizip-0.2.6-py3.9.egg-info
running install_scripts
writing list of installed files to '/usr/ports/archivers/py-pyminizip/work-py39/.PLIST.pymodtmp'
====> Compressing man pages (compress-man)
====> Running Q/A tests (stage-qa)
Warning: 'lib/python3.9/site-packages/pyminizip.cpython-39.so' is not stripped consider trying INSTALL_TARGET=install-strip
or using ${STRIP_CMD}
Error: '/usr/local/lib/python3.9/site-packages/pyminizip.cpython-39.so' is a architecture specific binary file and you have
set NO_ARCH. Either remove NO_ARCH or add 'pyminizip.cpython-39.so' to NO_ARCH_IGNORE.
*** Error code 1

Stop.
make: stopped in /usr/ports/archivers/py-pyminizip

This is on FreeBSD 13.2-RELEASE-p4, which is the most up-to-date stable version at this time. So if it should work correctly on any version of FreeBSD today, this would be it. Any assistance would be great as my code won't build without it. Thanks

[mephistolist]

Well, I just commented out NO_ARCH in this Makefile instead of my own and it worked. Maybe push that out to the FreeBSD port as it will break others. That's the solution though.