From e478f8a6cd86e50a23f649c274bde20f1a99b660 Mon Sep 17 00:00:00 2001 From: Eileen McNaughton Date: Tue, 6 Aug 2024 13:55:41 +1200 Subject: [PATCH] Php 8.4 support When running unit tests on php 8.4 I see ``` Deprecated: Smarty\Template::createCodeFrame(): Implicitly marking parameter $compiler as nullable is deprecated, the explicit nullable type must be used instead in /home/homer/buildkit/build/build-2/web/core/packages/smarty5/vendor/smarty/smarty/src/Template.php on line 465 ``` --- src/Template.php | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/Template.php b/src/Template.php index fcb0f58d2..63930a1fa 100644 --- a/src/Template.php +++ b/src/Template.php @@ -462,7 +462,7 @@ public function getCompiler() { * @return string * @throws Exception */ - public function createCodeFrame($content = '', $functions = '', $cache = false, \Smarty\Compiler\Template $compiler = null) { + public function createCodeFrame($content = '', $functions = '', $cache = false, ?\Smarty\Compiler\Template $compiler = null) { return $this->getCodeFrameCompiler()->create($content, $functions, $cache, $compiler); }