Skip to content

Conversation

@chray-zhang
Copy link
Collaborator

@chray-zhang chray-zhang commented Sep 4, 2025

Closes https://smartcontract-it.atlassian.net/browse/OPDATA-3889

Description

  • CSV Parsing has a strict structure that it follows or expects
  • Added a parser for both Russell and FTSE
  • Have a factory to determine parser based on instrument
  • Parser inherits from a base class

Google doc context: https://docs.google.com/document/d/1Jk7HrMddqBkBjWXx62FoIcwI8dSHbIvLsCvAhh76uV8/edit?tab=t.0

Quality Assurance

  • [x ] If a new adapter was made, or an existing one was modified so that its environment variables have changed, update the relevant infra-k8s configuration file.
  • [x ] If a new adapter was made, or an existing one was modified so that its environment variables have changed, update the relevant adapter-secrets configuration file or update the soak testing blacklist.
  • [x ] If a new adapter was made, or a new endpoint was added, update the test-payload.json file with relevant requests.
  • [ x] The branch naming follows git flow (feature/x, chore/x, release/x, hotfix/x, fix/x) or is created from Jira.
  • [ x] This is related to a maximum of one Jira story or GitHub issue.
  • [ x] Types are safe (avoid TypeScript/TSLint features like any and disable, instead use more specific types).
  • [ x] All code changes have 100% unit and integration test coverage. If testing is not applicable or too difficult to justify doing, the reasoning should be documented explicitly in the PR.

@changeset-bot
Copy link

changeset-bot bot commented Sep 4, 2025

🦋 Changeset detected

Latest commit: d1fb425

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@chainlink/ftse-sftp-adapter Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@chray-zhang chray-zhang changed the title Ftse utils [OPDATA-3889] Ftse EA Parsing Utils Sep 4, 2025
@chray-zhang chray-zhang requested a review from dskloetc September 5, 2025 16:49
@chray-zhang chray-zhang requested a review from a team as a code owner September 8, 2025 16:04
@chray-zhang chray-zhang requested a review from dskloetc September 8, 2025 16:04
@chray-zhang chray-zhang requested a review from dskloetc September 9, 2025 14:10
@dskloetc
Copy link
Contributor

dskloetc commented Sep 9, 2025

Can you tell me if you got an email notification for this comment, @chray-zhang?

@chray-zhang
Copy link
Collaborator Author

Test comment

@chray-zhang
Copy link
Collaborator Author

Test comment 2

@chray-zhang chray-zhang closed this Sep 9, 2025
@chray-zhang chray-zhang reopened this Sep 9, 2025
@chray-zhang chray-zhang requested review from Copilot and removed request for Copilot September 11, 2025 12:52
@chray-zhang chray-zhang enabled auto-merge (squash) September 11, 2025 16:33
@chray-zhang chray-zhang merged commit 5f3faa7 into main Sep 11, 2025
17 checks passed
@chray-zhang chray-zhang deleted the ftse-utils branch September 11, 2025 19:07
@github-actions github-actions bot mentioned this pull request Sep 11, 2025
@dskloetc dskloetc mentioned this pull request Sep 19, 2025
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants