Include webhook response in error message. #1516
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
github-actions
bot
added
the
needs triage
areed
approved these changes
Aug 25, 2023
maraino
approved these changes
Aug 25, 2023
Contributor
maraino
left a comment
maraino
left a comment
There was a problem hiding this comment.
lgtm, it won't look as expected if the response is not text.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pain or issue this feature alleviates:
Not having visibility in to errors during sign requests when a webhook is used.
Why is this important to the project (if not answered above):
Helps with troubleshooting eg: device attestation workflows.
💔Thank you!