Skip to content

Commit e8182ce

Browse files
anttercopybara-github
authored andcommitted
have 'bazel test' non-test targets depend on --remote_download_output
This fixes bazelbuild#17190 Closes bazelbuild#17195. PiperOrigin-RevId: 501555041 Change-Id: Ie52f72fb82912dde135eaa56c02d9756eb31365b
1 parent 36a93f9 commit e8182ce

File tree

1 file changed

+2
-2
lines changed

1 file changed

+2
-2
lines changed

src/main/java/com/google/devtools/build/lib/remote/ToplevelArtifactsDownloader.java

+2-2
Original file line numberDiff line numberDiff line change
@@ -184,9 +184,9 @@ private boolean shouldDownloadToplevelOutputs(ConfiguredTargetKey configuredTarg
184184
if (configuredTarget instanceof RuleConfiguredTarget) {
185185
var ruleConfiguredTarget = (RuleConfiguredTarget) configuredTarget;
186186
var isTestRule = isTestRuleName(ruleConfiguredTarget.getRuleClassString());
187-
return !isTestRule;
187+
return !isTestRule && downloadToplevel;
188188
}
189-
return true;
189+
return downloadToplevel;
190190
} catch (InterruptedException ignored) {
191191
Thread.currentThread().interrupt();
192192
return false;

0 commit comments

Comments
 (0)