Skip to content

Commit c45d6cc

Browse files
tjgqcopybara-github
authored andcommitted
Avoid creating a temporary list in AspectAwareAttributeMapper.getAttributeNames.
PiperOrigin-RevId: 509859496 Change-Id: Icf1e5b49b6690cc24597f49b2cc4fb68abea4d21
1 parent 1c03a1a commit c45d6cc

File tree

1 file changed

+2
-5
lines changed

1 file changed

+2
-5
lines changed

src/main/java/com/google/devtools/build/lib/analysis/AspectAwareAttributeMapper.java

+2-5
Original file line numberDiff line numberDiff line change
@@ -14,8 +14,8 @@
1414

1515
package com.google.devtools.build.lib.analysis;
1616

17-
import com.google.common.collect.ImmutableList;
1817
import com.google.common.collect.ImmutableMap;
18+
import com.google.common.collect.Iterables;
1919
import com.google.devtools.build.lib.cmdline.Label;
2020
import com.google.devtools.build.lib.packages.Attribute;
2121
import com.google.devtools.build.lib.packages.AttributeMap;
@@ -96,10 +96,7 @@ public boolean isConfigurable(String attributeName) {
9696

9797
@Override
9898
public Iterable<String> getAttributeNames() {
99-
return ImmutableList.<String>builder()
100-
.addAll(ruleAttributes.getAttributeNames())
101-
.addAll(aspectAttributes.keySet())
102-
.build();
99+
return Iterables.concat(ruleAttributes.getAttributeNames(), aspectAttributes.keySet());
103100
}
104101

105102
@Override

0 commit comments

Comments
 (0)