Skip to content

Commit 6e18829

Browse files
ShreeM01buildbreaker2021keertk
authored
[6.2.0]Expose cc_proto_aspect as a toplevel symbol. (bazelbuild#17980)
* Expose cc_proto_aspect as a toplevel symbol. PiperOrigin-RevId: 520619683 Change-Id: Ief39fdc3ea9083c22fbf12d2b4ba79482c3c16bf * Update CcRules.java * Revert change * Revert change * Revert * Update exports.bzl --------- Co-authored-by: Googler <[email protected]> Co-authored-by: keertk <[email protected]>
1 parent 41cfc6c commit 6e18829

File tree

4 files changed

+9
-5
lines changed

4 files changed

+9
-5
lines changed

src/main/java/com/google/devtools/build/lib/bazel/rules/CcRules.java

+1
Original file line numberDiff line numberDiff line change
@@ -65,6 +65,7 @@ public void init(ConfiguredRuleClassProvider.Builder builder) {
6565
GraphNodeAspect graphNodeAspect = new GraphNodeAspect();
6666
builder.addConfigurationFragment(CppConfiguration.class);
6767
builder.addStarlarkAccessibleTopLevels("CcSharedLibraryInfo", Starlark.NONE);
68+
builder.addStarlarkAccessibleTopLevels("cc_proto_aspect", Starlark.NONE);
6869
builder.addBuildInfoFactory(new CppBuildInfo());
6970

7071
builder.addNativeAspectClass(graphNodeAspect);

src/main/starlark/builtins_bzl/bazel/exports.bzl

+5-2
Original file line numberDiff line numberDiff line change
@@ -17,9 +17,12 @@
1717
load("@_builtins//:common/java/java_library.bzl", "java_library")
1818
load("@_builtins//:common/java/java_plugin.bzl", "java_plugin")
1919
load("@_builtins//:common/java/proto/java_proto_library.bzl", "java_proto_library")
20-
load("@_builtins//:common/cc/cc_proto_library.bzl", "cc_proto_library")
20+
load("@_builtins//:common/cc/cc_proto_library.bzl", "cc_proto_aspect", "cc_proto_library")
21+
22+
exported_toplevels = {
23+
"cc_proto_aspect": cc_proto_aspect
24+
}
2125

22-
exported_toplevels = {}
2326
exported_rules = {
2427
"java_library": java_library,
2528
"java_plugin": java_plugin,

src/main/starlark/builtins_bzl/common/cc/cc_proto_library.bzl

+2-2
Original file line numberDiff line numberDiff line change
@@ -256,7 +256,7 @@ def _aspect_impl(target, ctx):
256256
providers.append(header_provider)
257257
return providers
258258

259-
_cc_proto_aspect = aspect(
259+
cc_proto_aspect = aspect(
260260
implementation = _aspect_impl,
261261
attr_aspects = ["deps"],
262262
fragments = ["cpp", "proto"],
@@ -290,7 +290,7 @@ cc_proto_library = rule(
290290
implementation = _impl,
291291
attrs = {
292292
"deps": attr.label_list(
293-
aspects = [_cc_proto_aspect],
293+
aspects = [cc_proto_aspect],
294294
allow_rules = ["proto_library"],
295295
allow_files = False,
296296
),

src/test/java/com/google/devtools/build/lib/rules/cpp/proto/CcProtoLibraryTest.java

+1-1
Original file line numberDiff line numberDiff line change
@@ -51,7 +51,7 @@ public class CcProtoLibraryTest extends BuildViewTestCase {
5151
private final StarlarkAspectClass starlarkCcProtoAspect =
5252
new StarlarkAspectClass(
5353
Label.parseAbsoluteUnchecked("@_builtins//:common/cc/cc_proto_library.bzl"),
54-
"_cc_proto_aspect");
54+
"cc_proto_aspect");
5555

5656
@Before
5757
public void setUp() throws Exception {

0 commit comments

Comments
 (0)