Skip to content

Commit 2715120

Browse files
werktcopybara-github
authored andcommitted
Rename --experimental_remote_grpc_log to --remote_grpc_log
GRPC logging has been in use since the start of REAPI application to bazel, and is sufficiently stable and supported by tools_remote/remote_client RELNOTES: `--experimental_remote_grpc_log` has been renamed to `--remote_grpc_log` Closes bazelbuild#18180. PiperOrigin-RevId: 526633832 Change-Id: Ib3b06c303f39f1dd8e1eff3b5b4d4d146f148665
1 parent b447607 commit 2715120

File tree

2 files changed

+5
-4
lines changed

2 files changed

+5
-4
lines changed

src/main/java/com/google/devtools/build/lib/remote/RemoteModule.java

+2-2
Original file line numberDiff line numberDiff line change
@@ -405,11 +405,11 @@ public void beforeCommand(CommandEnvironment env) throws AbruptExitException {
405405
}
406406

407407
ClientInterceptor loggingInterceptor = null;
408-
if (remoteOptions.experimentalRemoteGrpcLog != null) {
408+
if (remoteOptions.remoteGrpcLog != null) {
409409
try {
410410
rpcLogFile =
411411
new AsynchronousFileOutputStream(
412-
env.getWorkingDirectory().getRelative(remoteOptions.experimentalRemoteGrpcLog));
412+
env.getWorkingDirectory().getRelative(remoteOptions.remoteGrpcLog));
413413
} catch (IOException e) {
414414
handleInitFailure(env, e, Code.RPC_LOG_FAILURE);
415415
return;

src/main/java/com/google/devtools/build/lib/remote/options/RemoteOptions.java

+3-2
Original file line numberDiff line numberDiff line change
@@ -378,7 +378,8 @@ public RemoteBuildEventUploadModeConverter() {
378378
public boolean experimentalGuardAgainstConcurrentChanges;
379379

380380
@Option(
381-
name = "experimental_remote_grpc_log",
381+
name = "remote_grpc_log",
382+
oldName = "experimental_remote_grpc_log",
382383
defaultValue = "null",
383384
category = "remote",
384385
documentationCategory = OptionDocumentationCategory.REMOTE,
@@ -391,7 +392,7 @@ public RemoteBuildEventUploadModeConverter() {
391392
+ "protobufs with each message prefixed by a varint denoting the size of the"
392393
+ " following serialized protobuf message, as performed by the method "
393394
+ "LogEntry.writeDelimitedTo(OutputStream).")
394-
public PathFragment experimentalRemoteGrpcLog;
395+
public PathFragment remoteGrpcLog;
395396

396397
@Option(
397398
name = "incompatible_remote_symlinks",

0 commit comments

Comments
 (0)