-
-
Notifications
You must be signed in to change notification settings - Fork 157
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Sanic support: parser, test app, tests #287
Conversation
Hi @dnikolayev . Thanks for your work on this! In order to keep this library small and easy to maintain, we've stopped adding support for new frameworks, so I'm going to close this. For now, I recommend adding webargs-sanic to https://github.com/sloria/webargs/wiki/Ecosystem . I'll forward people to that library when asked about sanic support. Also, would it help if |
Ok, I see. I already started to update docs and check contributing policies to pass everything, LOL As for the "CommonTestCase" - Well, I guess so. |
@dnikolayev I'll try to make a new release with CommonTestCase after work today |
Maybe we ought to update |
Thnx @sloria Thanks again for your help! |
* "Github" -> "GitHub" * strict=True only applies to marshmallow 2 * Add note about framework integration in CONTRIBUTING #287 (comment)
* "Github" -> "GitHub" * strict=True only applies to marshmallow 2 * Add note about framework integration in CONTRIBUTING #287 (comment)
@dnikolayev OK, 4.1.0 includes |
Also, I've updated CONTRIBUTING.rst. Good idea, @lafrech |
I removed a copy of common tests. @sloria, Thanks for your help! |
We commonly use webargs + flask.
However, there was a requirement to build a project using Sanic.
To have the same style support with common practice Sanic support was added.
Please review.
@sloria, to enable Sanic support webtest-sanic package was released. The code of webtest-sanic is fully based on your library webtest-aiohttp and all creds saved.