Don't use Spotlight for Xcode version detection #298
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Change cocoapods gem requirement to ~> 1.2 Allows us to remove the runtime check for an old version of xcodeproj (xcodeproj 0.28.2 is from 2015)
…ndex Xcode This should fix a number of misdetections where slather attempts to use gcov instead of clang
Closed
This was referenced Apr 7, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
slather was using mdls/Spotlight to detect Xcode's version. If mdls returned (null) then the Xcode version was detected as 0, which would cause it to use the gcov path by default.
This changes it so we read the Xcode version out of the plist directly.
This should fix issues like #297 where Spotlight hasn't indexed yet. It will likely fix issues like #262 as well.