Skip to content

Commit 624ba39

Browse files
author
AJ Steers
committed
optional logging path
1 parent 4352fad commit 624ba39

File tree

2 files changed

+4
-1
lines changed

2 files changed

+4
-1
lines changed

Diff for: catalog/aws/singer-taps/main.tf

+3-1
Original file line numberDiff line numberDiff line change
@@ -79,11 +79,13 @@ module "ecs_tap_sync_task" {
7979
{
8080
TAP_CONFIG_DIR = "${var.data_lake_metadata_path}/tap-snapshot-${local.unique_hash}",
8181
TAP_STATE_FILE = "${coalesce(var.data_lake_storage_path, var.data_lake_metadata_path)}/${var.state_file_naming_scheme}",
82-
TAP_LOG_DIR = "${var.data_lake_logging_path}/tap-${local.taps_specs[count.index].name}/",
8382
PIPELINE_VERSION_NUMBER = var.pipeline_version_number
8483
"${local.tap_env_prefix[count.index]}CONFIG_FILE" = "False" # Config will be passed via env vars
8584
"${local.target_env_prefix}CONFIG_FILE" = "False" # Config will be passed via env vars
8685
},
86+
var.data_lake_logging_path == null ? {} : {
87+
TAP_LOG_DIR = "${var.data_lake_logging_path}/tap-${local.taps_specs[count.index].name}/"
88+
},
8789
{
8890
for k, v in local.taps_specs[count.index].settings :
8991
"${local.tap_env_prefix[count.index]}${k}" => v

Diff for: catalog/aws/singer-taps/variables.tf

+1
Original file line numberDiff line numberDiff line change
@@ -107,6 +107,7 @@ The remote folder for storing tap execution logs and log artifacts.
107107
Currently only S3 paths (s3://...) are supported.
108108
EOF
109109
type = string
110+
default = null
110111
}
111112
variable "data_lake_metadata_path" {
112113
description = <<EOF

0 commit comments

Comments
 (0)