Use the problems API in more places (#1266)

<!--
  ⬆ Put your description above this! ⬆

  Please be descriptive and detailed.
  
Please read our [Contributing
Guidelines](https://github.com/tinyspeck/foundry/blob/main/.github/CONTRIBUTING.md)
and [Code of Conduct](https://slackhq.github.io/code-of-conduct).

Don't worry about deleting this, it's not visible in the PR!
-->

Author: ZacSweers

platforms/gradle/foundry-gradle-plugin/src/main/kotlin/foundry/gradle/FoundryShared.kt

@@ -0,0 +1,23 @@
+/*
+ * Copyright (C) 2025 Slack Technologies, LLC
+ *
+ * Licensed under the Apache License, Version 2.0 (the "License");
+ * you may not use this file except in compliance with the License.
+ * You may obtain a copy of the License at
+ *
+ *    https://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package foundry.gradle
+
+import org.gradle.api.problems.ProblemGroup
+
+internal object FoundryShared {
+  val PROBLEM_GROUP = ProblemGroup.create("foundry-group", "Foundry Problems")
+  const val FOUNDRY_TASK_GROUP = "foundry"
+}

platforms/gradle/foundry-gradle-plugin/src/main/kotlin/foundry/gradle/avoidance/ComputeAffectedProjectsTask.kt

@@ -18,6 +18,7 @@ package foundry.gradle.avoidance
 import com.jraska.module.graph.DependencyGraph
 import foundry.common.FoundryLogger
 import foundry.gradle.FoundryProperties
+import foundry.gradle.FoundryShared
 import foundry.gradle.properties.setDisallowChanges
 import foundry.gradle.property
 import foundry.gradle.util.gradle
@@ -105,7 +106,7 @@ public abstract class ComputeAffectedProjectsTask : DefaultTask() {
   @get:Internal internal abstract val rootDir: DirectoryProperty
 
   init {
-    group = "foundry"
+    group = FoundryShared.FOUNDRY_TASK_GROUP
     description = "Computes affected projects and writes output files to an output directory."
   }
 

platforms/gradle/foundry-gradle-plugin/src/main/kotlin/foundry/gradle/stats/ModuleStats.kt

@@ -23,6 +23,7 @@ import com.squareup.moshi.JsonClass
 import com.squareup.wire.gradle.WireTask
 import foundry.common.json.JsonTools
 import foundry.gradle.FoundryProperties
+import foundry.gradle.FoundryShared
 import foundry.gradle.artifacts.FoundryArtifact
 import foundry.gradle.artifacts.Publisher
 import foundry.gradle.artifacts.Resolver
@@ -262,7 +263,7 @@ public abstract class ModuleStatsAggregatorTask : DefaultTask() {
   @get:OutputFile public abstract val outputFile: RegularFileProperty
 
   init {
-    group = "foundry"
+    group = FoundryShared.FOUNDRY_TASK_GROUP
   }
 
   @TaskAction
@@ -365,7 +366,7 @@ internal abstract class ModuleStatsCollectorTask @Inject constructor(objects: Ob
   @get:OutputFile abstract val outputFile: RegularFileProperty
 
   init {
-    group = "foundry"
+    group = FoundryShared.FOUNDRY_TASK_GROUP
   }
 
   @TaskAction

platforms/gradle/foundry-gradle-plugin/src/main/kotlin/foundry/gradle/tasks/AndroidTestApksTask.kt

@@ -15,6 +15,7 @@
  */
 package foundry.gradle.tasks
 
+import foundry.gradle.FoundryShared
 import foundry.gradle.artifacts.FoundryArtifact
 import foundry.gradle.artifacts.Resolver
 import foundry.gradle.properties.setDisallowChanges
@@ -51,7 +52,7 @@ public abstract class AndroidTestApksTask : DefaultTask() {
   @get:OutputFile public abstract val outputFile: RegularFileProperty
 
   init {
-    group = "foundry"
+    group = FoundryShared.FOUNDRY_TASK_GROUP
   }
 
   @OptIn(ExperimentalPathApi::class)

platforms/gradle/foundry-gradle-plugin/src/main/kotlin/foundry/gradle/tasks/CheckManifestPermissionsTask.kt

@@ -15,13 +15,19 @@
  */
 package foundry.gradle.tasks
 
+import foundry.gradle.FoundryShared
 import java.io.File
+import javax.inject.Inject
 import javax.xml.parsers.DocumentBuilderFactory
 import kotlin.system.measureTimeMillis
 import okio.buffer
 import okio.source
 import org.gradle.api.DefaultTask
+import org.gradle.api.GradleException
 import org.gradle.api.file.RegularFileProperty
+import org.gradle.api.problems.ProblemId
+import org.gradle.api.problems.Problems
+import org.gradle.api.problems.Severity
 import org.gradle.api.provider.SetProperty
 import org.gradle.api.tasks.CacheableTask
 import org.gradle.api.tasks.Input
@@ -32,9 +38,9 @@ import org.gradle.api.tasks.PathSensitivity
 import org.gradle.api.tasks.TaskAction
 import org.w3c.dom.NodeList
 
-@Suppress("UnstableApiUsage")
 @CacheableTask
-internal abstract class CheckManifestPermissionsTask : DefaultTask() {
+internal abstract class CheckManifestPermissionsTask @Inject constructor(problems: Problems) :
+  DefaultTask() {
 
   @get:PathSensitive(PathSensitivity.NONE)
   @get:InputFile
@@ -52,6 +58,8 @@ internal abstract class CheckManifestPermissionsTask : DefaultTask() {
 
   @get:Input abstract val permissionAllowlist: SetProperty<String>
 
+  private val problemReporter = problems.reporter
+
   @TaskAction
   fun check() {
     measureTimeMillis {
@@ -68,24 +76,38 @@ internal abstract class CheckManifestPermissionsTask : DefaultTask() {
         logger.debug("$LOG ${permissions.size} parsed permissions: $permissions")
 
         val added = permissions - allowlist
+        val removed = allowlist - permissions
+        var exception: PermissionAllowlistException? = null
+        var solution = ""
         if (added.isNotEmpty()) {
-          throw PermissionAllowlistException(
-            "New permission(s) detected! If this is intentional, " +
-              "please add them to $allowlistFile and update your PR (a code owners group will be " +
-              "added for review). Added permissions: $added"
-          )
+          exception = PermissionAllowlistException("New permission(s) detected!")
+          solution =
+            "If this is intentional, please add them to $allowlistFile and " +
+              "update your PR (a code owners group will be added for review)." +
+              "Added permissions: $added"
+        } else if (removed.isNotEmpty()) {
+          exception = PermissionAllowlistException("Removed permission(s) detected!")
+          solution =
+            "If this is intentional, please remove them to $allowlistFile and update " +
+              "your PR (a code owners group will be added for review)." +
+              "Removed permissions: $removed"
         }
 
-        val removed = allowlist - permissions
-        if (removed.isNotEmpty()) {
-          throw PermissionAllowlistException(
-            "Removed permission(s) detected! If this is " +
-              "intentional, please remove them to $allowlistFile and update your PR (a code owners " +
-              "group will be added for review). Removed permissions: $removed"
-          )
+        if (exception == null) {
+          manifestFile.copyTo(outputFile.asFile.get(), overwrite = true)
+        } else {
+          val problemId =
+            ProblemId.create(
+              "permission-allowlist",
+              "Manifest permission check failure",
+              FoundryShared.PROBLEM_GROUP,
+            )
+          problemReporter.throwing(exception, problemId) {
+            fileLocation(manifestFile.absolutePath)
+            solution(solution)
+            severity(Severity.ERROR)
+          }
         }
-
-        manifestFile.copyTo(outputFile.asFile.get(), overwrite = true)
       }
       .let { logger.debug("$LOG Manifest perm checks took $it ms") }
   }
@@ -117,4 +139,4 @@ internal abstract class CheckManifestPermissionsTask : DefaultTask() {
   }
 }
 
-internal class PermissionAllowlistException(message: String) : RuntimeException(message)
+internal class PermissionAllowlistException(message: String) : GradleException(message)

platforms/gradle/foundry-gradle-plugin/src/main/kotlin/foundry/gradle/tasks/InstallCommitHooksTask.kt

@@ -16,6 +16,7 @@
 package foundry.gradle.tasks
 
 import com.google.common.io.Resources
+import foundry.gradle.FoundryShared
 import foundry.gradle.setProperty
 import java.io.File
 import javax.inject.Inject
@@ -46,7 +47,7 @@ constructor(layout: ProjectLayout, objects: ObjectFactory) : DefaultTask() {
     objects.directoryProperty().convention(layout.projectDirectory.dir("config/git/hooks"))
 
   init {
-    group = "foundry"
+    group = FoundryShared.FOUNDRY_TASK_GROUP
     description = "Installs basic git hook files for formatting to a given output directory."
   }
 

platforms/gradle/foundry-gradle-plugin/src/main/kotlin/foundry/gradle/tasks/PrintFossaDependencies.kt

@@ -15,6 +15,7 @@
  */
 package foundry.gradle.tasks
 
+import foundry.gradle.FoundryShared
 import foundry.gradle.capitalizeUS
 import foundry.gradle.properties.setDisallowChanges
 import foundry.gradle.register
@@ -46,7 +47,7 @@ public abstract class PrintFossaDependencies : BaseDependencyCheckTask() {
   @get:OutputFile public abstract val outputFile: RegularFileProperty
 
   init {
-    group = "foundry"
+    group = FoundryShared.FOUNDRY_TASK_GROUP
   }
 
   override fun handleDependencies(identifiersToVersions: Map<String, String>) {

platforms/gradle/foundry-gradle-plugin/src/main/kotlin/foundry/gradle/tasks/ValidateVersionsMatch.kt

@@ -15,12 +15,20 @@
  */
 package foundry.gradle.tasks
 
+import foundry.gradle.FoundryShared
 import foundry.gradle.FoundryVersions
 import foundry.gradle.capitalizeUS
 import foundry.gradle.register
+import javax.inject.Inject
+import kotlin.io.path.absolutePathString
+import kotlin.io.path.readText
 import org.gradle.api.DefaultTask
+import org.gradle.api.GradleException
 import org.gradle.api.Project
 import org.gradle.api.file.RegularFileProperty
+import org.gradle.api.problems.ProblemId
+import org.gradle.api.problems.Problems
+import org.gradle.api.problems.Severity
 import org.gradle.api.provider.Property
 import org.gradle.api.tasks.CacheableTask
 import org.gradle.api.tasks.Input
@@ -41,7 +49,8 @@ import org.gradle.api.tasks.TaskAction
  * want a single manifest file.
  */
 @CacheableTask
-public abstract class ValidateVersionsMatch : DefaultTask(), FoundryValidationTask {
+public abstract class ValidateVersionsMatch @Inject constructor(problems: Problems) :
+  DefaultTask(), FoundryValidationTask {
   @get:InputFile
   @get:PathSensitive(PathSensitivity.NONE)
   public abstract val versionFile: RegularFileProperty
@@ -52,20 +61,39 @@ public abstract class ValidateVersionsMatch : DefaultTask(), FoundryValidationTa
 
   @get:OutputFile public abstract val outputFile: RegularFileProperty
 
+  private val problemReporter = problems.reporter
+
   init {
-    group = "foundry"
+    group = FoundryShared.FOUNDRY_TASK_GROUP
   }
 
   @TaskAction
   internal fun validate() {
-    val fileVersion = versionFile.asFile.get().readText().trim()
+    val versionFilePath = versionFile.asFile.get().toPath()
+    val fileVersion = versionFilePath.readText().trim()
     val requiredVersion = catalogVersion.get()
 
-    check(fileVersion == requiredVersion) {
-      "Version ($fileVersion) in file '${versionFileRelativePath.get()}' does not match the version in ${catalogName.get()}.versions.toml ($requiredVersion). Please ensure these are aligned"
+    val valid = fileVersion == requiredVersion
+    if (!valid) {
+      val problemId =
+        ProblemId.create(
+          "validate-versions-match",
+          "Versions mismatch",
+          FoundryShared.PROBLEM_GROUP,
+        )
+      problemReporter.throwing(
+        GradleException(
+          "Version ($fileVersion) in file '${versionFileRelativePath.get()}' does not match the version in ${catalogName.get()}.versions.toml ($requiredVersion)."
+        ),
+        problemId,
+      ) {
+        fileLocation(versionFilePath.absolutePathString())
+        solution("Ensure these versions are aligned.")
+        severity(Severity.ERROR)
+      }
     }
 
-    outputFile.asFile.get().writeText("valid")
+    outputFile.asFile.get().writeText(valid.toString())
   }
 
   internal companion object {

platforms/gradle/foundry-gradle-plugin/src/main/kotlin/foundry/gradle/tasks/robolectric/UpdateRobolectricJarsTask.kt

@@ -16,6 +16,7 @@
 package foundry.gradle.tasks.robolectric
 
 import foundry.gradle.FoundryProperties
+import foundry.gradle.FoundryShared
 import foundry.gradle.properties.setDisallowChanges
 import foundry.gradle.register
 import foundry.gradle.robolectricJars
@@ -61,7 +62,7 @@ internal abstract class UpdateRobolectricJarsTask : DefaultTask(), BootstrapTask
   @get:Internal abstract val outputDir: DirectoryProperty
 
   init {
-    group = "foundry"
+    group = FoundryShared.FOUNDRY_TASK_GROUP
     description = "Downloads the Robolectric android-all jars."
   }
 

platforms/gradle/foundry-gradle-plugin/src/main/kotlin/foundry/gradle/topography/ModuleTopographyTask.kt

@@ -19,6 +19,7 @@ import foundry.cli.walkEachFile
 import foundry.common.json.JsonTools
 import foundry.gradle.FoundryExtension
 import foundry.gradle.FoundryProperties
+import foundry.gradle.FoundryShared
 import foundry.gradle.artifacts.FoundryArtifact
 import foundry.gradle.artifacts.Publisher
 import foundry.gradle.artifacts.Resolver
@@ -47,7 +48,6 @@ import org.gradle.api.Project
 import org.gradle.api.file.DirectoryProperty
 import org.gradle.api.file.RegularFileProperty
 import org.gradle.api.internal.plugins.PluginRegistry
-import org.gradle.api.problems.ProblemGroup
 import org.gradle.api.problems.ProblemId
 import org.gradle.api.problems.Problems
 import org.gradle.api.problems.Severity
@@ -173,7 +173,7 @@ public abstract class ModuleTopographyTask : DefaultTask() {
   @get:OutputFile public abstract val topographyOutputFile: RegularFileProperty
 
   init {
-    group = "foundry"
+    group = FoundryShared.FOUNDRY_TASK_GROUP
   }
 
   @TaskAction
@@ -219,7 +219,7 @@ public abstract class ValidateModuleTopographyTask @Inject constructor(problems:
   private val problemReporter = problems.reporter
 
   init {
-    group = "foundry"
+    group = FoundryShared.FOUNDRY_TASK_GROUP
     @Suppress("LeakingThis")
     notCompatibleWithConfigurationCache("This task modified build files in place")
     @Suppress("LeakingThis") doNotTrackState("This task modified build files in place")
@@ -337,7 +337,11 @@ public abstract class ValidateModuleTopographyTask @Inject constructor(problems:
     exception: GradleException = GradleException(),
   ) {
     val problemId =
-      ProblemId.create("module-topography-validation", "Module validation failed!", PROBLEM_GROUP)
+      ProblemId.create(
+        "module-topography-validation",
+        "Module validation failed!",
+        FoundryShared.PROBLEM_GROUP,
+      )
     problemReporter.throwing(exception, problemId) {
       fileLocation(buildFile.relativeTo(rootDirProperty.asFile.get().toPath()).toString())
       solution(solution)
@@ -374,7 +378,6 @@ public abstract class ValidateModuleTopographyTask @Inject constructor(problems:
     private const val NAME = "validateModuleTopography"
     private val CI_NAME = "ci${NAME.capitalizeUS()}"
     internal val GLOBAL_CI_NAME = "global${CI_NAME.capitalizeUS()}"
-    val PROBLEM_GROUP = ProblemGroup.create("sample-group", "Sample Group")
 
     fun register(
       project: Project,