Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #1363 Wrong element type for timestamp in RichTextSectionElement.Date #1364

Merged
merged 5 commits into from
Sep 10, 2024
Merged

Fix #1363 Wrong element type for timestamp in RichTextSectionElement.Date #1364

Changes from 2 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
53ce315
fix: align timestamp with https://api.slack.com/reference/block-kit/b…
jed204 Sep 7, 2024
8acab7b
change to long
jed204 Sep 9, 2024
f6be07f
fix: unit tests
jed204 Sep 10, 2024
2c32abd
fix: more mock adjustments
jed204 Sep 10, 2024
26b659a
Merge branch 'main' into main
seratch Sep 10, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion slack-api-model/src/main/java/com/slack/api/model/block/element/RichTextSectionElement.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,7 +54,7 @@ public static class Link implements RichTextElement {
public static class Date implements RichTextElement {
public static final String TYPE = "date";
private final String type = TYPE;
private String timestamp;
private Long timestamp;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch 💯 I think this may be an integer on the backend, but this project uses Long for other timestamp values

private String format;
private TextStyle style;
private String url;
Expand Down
Loading