From 276eae6e2253f4b1ccf68f6f337f1810885b7e38 Mon Sep 17 00:00:00 2001
From: William Bergamin <wbergamin@salesforce.com>
Date: Wed, 29 Jan 2025 21:27:38 +0000
Subject: [PATCH] test: fix broken tests due to wild card import (#1240)

---
 .github/workflows/tests.yml                       | 1 +
 requirements/adapter.txt                          | 2 +-
 tests/adapter_tests/starlette/test_fastapi.py     | 3 ++-
 tests/adapter_tests/starlette/test_starlette.py   | 3 ++-
 tests/adapter_tests_async/test_async_fastapi.py   | 3 ++-
 tests/adapter_tests_async/test_async_starlette.py | 3 ++-
 6 files changed, 10 insertions(+), 5 deletions(-)

diff --git a/.github/workflows/tests.yml b/.github/workflows/tests.yml
index c0b58b9d7..d8fe75de9 100644
--- a/.github/workflows/tests.yml
+++ b/.github/workflows/tests.yml
@@ -11,6 +11,7 @@ jobs:
     runs-on: ubuntu-20.04
     timeout-minutes: 10
     strategy:
+      fail-fast: false
       matrix:
         python-version:
           - "3.6"
diff --git a/requirements/adapter.txt b/requirements/adapter.txt
index 7a09fae46..ee8bb5389 100644
--- a/requirements/adapter.txt
+++ b/requirements/adapter.txt
@@ -16,7 +16,7 @@ pyramid>=1,<3
 sanic>=20,<21; python_version=="3.6"
 sanic>=21,<24; python_version>"3.6" and python_version<="3.8"
 sanic>=21,<25; python_version>"3.8"
-starlette>=0.14,<1
+starlette>=0.19.1,<1
 tornado>=6,<7
 uvicorn<1                                # The oldest version can vary among Python runtime versions
 gunicorn>=20,<24
diff --git a/tests/adapter_tests/starlette/test_fastapi.py b/tests/adapter_tests/starlette/test_fastapi.py
index aa16ffa69..64e633fe2 100644
--- a/tests/adapter_tests/starlette/test_fastapi.py
+++ b/tests/adapter_tests/starlette/test_fastapi.py
@@ -206,7 +206,8 @@ async def endpoint(req: Request):
             return await app_handler.handle(req)
 
         client = TestClient(api)
-        response = client.get("/slack/install", allow_redirects=False)
+        client.follow_redirects = False
+        response = client.get("/slack/install")
         assert response.status_code == 200
         assert response.headers.get("content-type") == "text/html; charset=utf-8"
         assert "https://slack.com/oauth/v2/authorize?state=" in response.text
diff --git a/tests/adapter_tests/starlette/test_starlette.py b/tests/adapter_tests/starlette/test_starlette.py
index 66bf163cb..8c6154b3b 100644
--- a/tests/adapter_tests/starlette/test_starlette.py
+++ b/tests/adapter_tests/starlette/test_starlette.py
@@ -215,7 +215,8 @@ async def endpoint(req: Request):
             routes=[Route("/slack/install", endpoint=endpoint, methods=["GET"])],
         )
         client = TestClient(api)
-        response = client.get("/slack/install", allow_redirects=False)
+        client.follow_redirects = False
+        response = client.get("/slack/install")
         assert response.status_code == 200
         assert response.headers.get("content-type") == "text/html; charset=utf-8"
         assert "https://slack.com/oauth/v2/authorize?state=" in response.text
diff --git a/tests/adapter_tests_async/test_async_fastapi.py b/tests/adapter_tests_async/test_async_fastapi.py
index 311c802fe..ea9308842 100644
--- a/tests/adapter_tests_async/test_async_fastapi.py
+++ b/tests/adapter_tests_async/test_async_fastapi.py
@@ -206,7 +206,8 @@ async def endpoint(req: Request):
             return await app_handler.handle(req)
 
         client = TestClient(api)
-        response = client.get("/slack/install", allow_redirects=False)
+        client.follow_redirects = False
+        response = client.get("/slack/install")
         assert response.status_code == 200
         assert response.headers.get("content-type") == "text/html; charset=utf-8"
         assert response.headers.get("content-length") == "607"
diff --git a/tests/adapter_tests_async/test_async_starlette.py b/tests/adapter_tests_async/test_async_starlette.py
index db3a68a56..7e9a18a58 100644
--- a/tests/adapter_tests_async/test_async_starlette.py
+++ b/tests/adapter_tests_async/test_async_starlette.py
@@ -216,7 +216,8 @@ async def endpoint(req: Request):
         )
 
         client = TestClient(api)
-        response = client.get("/slack/install", allow_redirects=False)
+        client.follow_redirects = False
+        response = client.get("/slack/install")
         assert response.status_code == 200
         assert response.headers.get("content-type") == "text/html; charset=utf-8"
         assert response.headers.get("content-length") == "607"